Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4331)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelOrderController.java

Issue 2931433004: [Android] Open a tab in the background from Browser Actions if ChromeTabbedActivity is available (Closed)
Patch Set: Fix test failures. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelOrderController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelOrderController.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelOrderController.java
index 0393d37330031f4ef40d9c28b1051b624c5ac10c..856ba0f0c3b118e76bbb530a460f0014b9f57f6c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelOrderController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelOrderController.java
@@ -30,6 +30,7 @@ public class TabModelOrderController {
* @return Where to insert the tab.
*/
public int determineInsertionIndex(TabLaunchType type, int position, Tab newTab) {
+ if (type == TabLaunchType.FROM_BROWSER_ACTIONS) return -1;
if (linkClicked(type)) {
position = determineInsertionIndex(type, newTab);
}
@@ -132,7 +133,9 @@ public class TabModelOrderController {
*/
public boolean willOpenInForeground(TabLaunchType type, boolean isNewTabIncognito) {
// Restore is handling the active index by itself.
- if (type == TabLaunchType.FROM_RESTORE) return false;
+ if (type == TabLaunchType.FROM_RESTORE || type == TabLaunchType.FROM_BROWSER_ACTIONS) {
+ return false;
+ }
return type != TabLaunchType.FROM_LONGPRESS_BACKGROUND
|| (!mTabModelSelector.isIncognitoSelected() && isNewTabIncognito);
}

Powered by Google App Engine
This is Rietveld 408576698