Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2479)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java

Issue 2931433004: [Android] Open a tab in the background from Browser Actions if ChromeTabbedActivity is available (Closed)
Patch Set: Fix test failures. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
index 101e7f65f40698a52e005ef66364076dbec0d349..7e9b2c246d5b9225cc7241e28944341c2cf7ff4e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
@@ -6,6 +6,7 @@ package org.chromium.chrome.browser.contextmenu;
import android.app.Activity;
import android.graphics.drawable.Drawable;
+import android.os.StrictMode;
import android.util.Pair;
import android.view.LayoutInflater;
import android.view.View;
@@ -91,20 +92,26 @@ class TabularContextMenuListAdapter extends BaseAdapter {
viewHolder.mIcon.setVisibility(icon != null ? View.VISIBLE : View.INVISIBLE);
if (menuItem instanceof ShareContextMenuItem) {
- final Pair<Drawable, CharSequence> shareInfo =
- ((ShareContextMenuItem) menuItem).getShareInfo();
- if (shareInfo.first != null) {
- viewHolder.mShareIcon.setImageDrawable(shareInfo.first);
- viewHolder.mShareIcon.setVisibility(View.VISIBLE);
- viewHolder.mShareIcon.setContentDescription(mActivity.getString(
- R.string.accessibility_menu_share_via, shareInfo.second));
- viewHolder.mShareIcon.setOnClickListener(new View.OnClickListener() {
- @Override
- public void onClick(View view) {
- mOnDirectShare.onResult(((ShareContextMenuItem) menuItem).isShareLink());
- }
- });
- viewHolder.mRightPadding.setVisibility(View.GONE);
+ StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
+ try {
+ final Pair<Drawable, CharSequence> shareInfo =
+ ((ShareContextMenuItem) menuItem).getShareInfo();
+ if (shareInfo.first != null) {
+ viewHolder.mShareIcon.setImageDrawable(shareInfo.first);
+ viewHolder.mShareIcon.setVisibility(View.VISIBLE);
+ viewHolder.mShareIcon.setContentDescription(mActivity.getString(
+ R.string.accessibility_menu_share_via, shareInfo.second));
+ viewHolder.mShareIcon.setOnClickListener(new View.OnClickListener() {
+ @Override
+ public void onClick(View view) {
+ mOnDirectShare.onResult(
+ ((ShareContextMenuItem) menuItem).isShareLink());
+ }
+ });
+ viewHolder.mRightPadding.setVisibility(View.GONE);
+ }
+ } finally {
+ StrictMode.setThreadPolicy(oldPolicy);
}
} else {
viewHolder.mShareIcon.setVisibility(View.GONE);

Powered by Google App Engine
This is Rietveld 408576698