chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java - Issue 2931433004: [Android] Open a tab in the background from Browser Actions if ChromeTabbedActivity is available

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

Issue 2931433004: [Android] Open a tab in the background from Browser Actions if ChromeTabbedActivity is available (Closed)

Patch Set: Update based on Yusuf's comment.s Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuItemDelegate.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuItemDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

index 103e6919c126c6ef39549d1f16201dc54edb5a31..c5c6f2d4608f2b82c308b83656fa8787db66d68d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

@@ -150,7 +150,6 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {

tab.loadUrl(loadUrlParams);

}

tab.getTabRedirectHandler().updateIntent(intent);

if (intent != null && intent.hasExtra(ServiceTabLauncher.LAUNCH_REQUEST_ID_EXTRA)) {

ServiceTabLauncher.onWebContentsForRequestAvailable(

intent.getIntExtra(ServiceTabLauncher.LAUNCH_REQUEST_ID_EXTRA, 0),

@@ -298,6 +297,7 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {

case FROM_RESTORE:

case FROM_LINK:

case FROM_EXTERNAL_APP:

+ case FROM_BROWSER_ACTIONS:

transition = PageTransition.LINK | PageTransition.FROM_API;

break;

case FROM_CHROME_UI: