Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1375)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java

Issue 2931433004: [Android] Open a tab in the background from Browser Actions if ChromeTabbedActivity is available (Closed)
Patch Set: Update based on Yusuf's comment.s Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java
index de634b39efa9930ba3656cc24a0e8b28903f20f4..49342e93dd15db2838099f9c9df22678456d76ce 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java
@@ -37,6 +37,7 @@ public class BrowserActionActivity extends AsyncInitializationActivity {
private String mCreatorPackageName;
private List<BrowserActionItem> mActions = new ArrayList<>();
private BrowserActionsContextMenuHelper mHelper;
+ private boolean mIsNativeInitialized;
@Override
protected void setContentView() {
@@ -162,4 +163,18 @@ public class BrowserActionActivity extends AsyncInitializationActivity {
public String getCreatorPackageName() {
return mCreatorPackageName;
}
+
+ @Override
+ public void finishNativeInitialization() {
+ super.finishNativeInitialization();
+ mIsNativeInitialized = true;
+ mHelper.handlePendingActions();
+ }
+
+ /**
+ * @return Whether Chrome native libraries are loaded.
+ */
+ public boolean isNativeInitialized() {
Yusuf 2017/07/10 06:14:56 We actually dont even need this, since we already
ltian 2017/07/26 01:22:12 Done.
+ return mIsNativeInitialized;
+ }
}

Powered by Google App Engine
This is Rietveld 408576698