[Android] Open a tab in the background from Browser Actions if ChromeTabbedActivity is available

chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuHelper.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.browseractions;
 
 import android.app.PendingIntent;
 import android.support.customtabs.browseractions.BrowserActionItem;
 import android.support.customtabs.browseractions.BrowserActionsIntent;
 import android.util.Pair;
@@ skipping 46 matching lines @@
     private final ContextMenuParams mCurrentContextMenuParams;
     private final BrowserActionsContextMenuItemDelegate mDelegate;
     private final BrowserActionActivity mActivity;
     private final Callback<Integer> mItemSelectedCallback;
     private final Runnable mOnMenuShown;
     private final Runnable mOnMenuClosed;
     private final Runnable mOnShareClickedRunnable;
 
     private final List<Pair<Integer, List<ContextMenuItem>>> mItems;
 
+    private boolean mIsOpenInBackgroundPending;
+
     public BrowserActionsContextMenuHelper(BrowserActionActivity activity, ContextMenuParams params,
             List<BrowserActionItem> customItems, String sourcePackageName) {
         mActivity = activity;
         mCurrentContextMenuParams = params;
         mOnMenuShown = new Runnable() {
             @Override
             public void run() {
                 mActivity.onMenuShown();
             }
         };
         mOnMenuClosed = new Runnable() {
             @Override
             public void run() {
-                mActivity.finish();
+                if (!mIsOpenInBackgroundPending) {
+                    mActivity.finish();

[Yusuf, 2017/06/29 19:05:26]

one line

[ltian, 2017/06/30 23:57:56]

The "git cl format" forces this to be into multiple lines.

+                }
             }
         };
         mItemSelectedCallback = new Callback<Integer>() {
             @Override
             public void onResult(Integer result) {
                 onItemSelected(result);
             }
         };
         mOnShareClickedRunnable = new Runnable() {
             @Override
@@ skipping 29 matching lines @@
         for (int i = 0; i < customItems.size() && i < BrowserActionsIntent.MAX_CUSTOM_ITEMS; i++) {
             items.add(new BrowserActionsCustomContextMenuItem(
                     CUSTOM_BROWSER_ACTIONS_ID_GROUP.get(i), customItems.get(i)));
             mCustomItemActionMap.put(
                     CUSTOM_BROWSER_ACTIONS_ID_GROUP.get(i), customItems.get(i).getAction());
         }
     }
 
     private boolean onItemSelected(int itemId) {
         if (itemId == R.id.browser_actions_open_in_background) {
-            mDelegate.onOpenInBackground(mCurrentContextMenuParams.getLinkUrl());
+            if (mActivity.isNatvieInitialized()) {
+                mDelegate.onOpenInBackground(mCurrentContextMenuParams.getLinkUrl());

[Yusuf, 2017/06/29 19:05:26]

maybe this is all the delegate's job? 

[ltian, 2017/06/30 23:57:56]

I feel the delegate is only responsible for executing each task and the helper
class takes charge of scheduling everything. So maybe moving all ProgressDialog
related code to this class is better?

+            } else {
+                mIsOpenInBackgroundPending = true;
+                mActivity.waitNativeInitialized();
+            }
         } else if (itemId == R.id.browser_actions_open_in_incognito_tab) {
             mDelegate.onOpenInIncognitoTab(mCurrentContextMenuParams.getLinkUrl());
         } else if (itemId == R.id.browser_actions_save_link_as) {
             mDelegate.startDownload(mCurrentContextMenuParams.getLinkUrl());
         } else if (itemId == R.id.browser_actions_copy_address) {
             mDelegate.onSaveToClipboard(mCurrentContextMenuParams.getLinkUrl());
         } else if (itemId == R.id.browser_actions_share) {
             mDelegate.share(false, mCurrentContextMenuParams.getLinkUrl());
         } else if (mCustomItemActionMap.indexOfKey(itemId) >= 0) {
             mDelegate.onCustomItemSelected(mCustomItemActionMap.get(itemId));
@@ skipping 31 matching lines @@
 
     @Override
     public void onViewAttachedToWindow(View view) {
         if (view.showContextMenu()) {
             mOnMenuShown.run();
         }
     }
 
     @Override
     public void onViewDetachedFromWindow(View v) {}
+
+    /**
+     * Finishes all pending actions which requires Chrome native libraries.
+     */
+    public void handlePendingActions() {
+        if (mIsOpenInBackgroundPending) {
+            mIsOpenInBackgroundPending = false;
+            mDelegate.onOpenInBackground(mCurrentContextMenuParams.getLinkUrl());
+            mActivity.finish();
+        }
+    }
 }