Disable hover state change for touch event on page with viewport meta and mobile.

third_party/WebKit/Source/web/tests/WebFrameTest.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 11638 matching lines @@
   EXPECT_EQ(scrollbar->HoveredPart(), ScrollbarPart::kNoPart);
 
   // Mouse moved over the scrollbar.
   WebMouseEvent mouse_move_over_scrollbar(
       WebInputEvent::kMouseMove, WebFloatPoint(175, 1), WebFloatPoint(175, 1),
       WebPointerProperties::Button::kNoButton, 0, WebInputEvent::kNoModifiers,
       TimeTicks::Now().InSeconds());
   mouse_move_over_scrollbar.SetFrameScale(1);
   document->GetFrame()->GetEventHandler().HandleMouseMoveEvent(
       mouse_move_over_scrollbar, Vector<WebMouseEvent>());
-  HitTestResult hit_test_result =
-      web_view->CoreHitTestResultAt(WebPoint(175, 1));
   EXPECT_EQ(scrollbar->PressedPart(), ScrollbarPart::kNoPart);
   EXPECT_EQ(scrollbar->HoveredPart(), ScrollbarPart::kThumbPart);
 
   // Mouse pressed.
   WebMouseEvent mouse_press_event(
       WebInputEvent::kMouseDown, WebFloatPoint(175, 1), WebFloatPoint(175, 1),
       WebPointerProperties::Button::kLeft, 0,
       WebInputEvent::Modifiers::kLeftButtonDown, TimeTicks::Now().InSeconds());
   mouse_press_event.SetFrameScale(1);
   document->GetFrame()->GetEventHandler().HandleMousePressEvent(
@@ skipping 17 matching lines @@
       WebInputEvent::kMouseUp, WebFloatPoint(1, 1), WebFloatPoint(1, 1),
       WebPointerProperties::Button::kLeft, 0,
       WebInputEvent::Modifiers::kLeftButtonDown, TimeTicks::Now().InSeconds());
   mouse_release_event.SetFrameScale(1);
   document->GetFrame()->GetEventHandler().HandleMouseReleaseEvent(
       mouse_release_event);
   EXPECT_EQ(scrollbar->PressedPart(), ScrollbarPart::kNoPart);
   EXPECT_EQ(scrollbar->HoveredPart(), ScrollbarPart::kNoPart);
 }
 
+class TapChangeHoverStateTest : public WebFrameTest {
+ public:
+  void RunTest(bool viewport_enabled,
+               bool viewport_meta,
+               bool should_change_hover_state) {
+    std::string test_page =
+        viewport_meta ? "viewport-2-div.html" : "noviewport-2-div.html";
+
+    FakeCompositingWebViewClient client;
+    RegisterMockedHttpURLLoad(test_page);
+    FrameTestHelpers::WebViewHelper web_view_helper;
+    WebViewBase* web_view;
+    if (viewport_enabled) {
+      web_view = web_view_helper.InitializeAndLoad(base_url_ + test_page, false,
+                                                   nullptr, &client, nullptr,
+                                                   ConfigureAndroid);
+      ApplyViewportStyleOverride(&web_view_helper);

[bokan, 2017/06/09 19:27:55]

Lets avoid this since it uses DevTools emulation so I'd rather not depend on
that. Just load a different html file that has a viewport <meta> or add one
dynamically.

+    } else {
+      web_view = web_view_helper.InitializeAndLoad(base_url_ + test_page);
+    }
+    web_view_helper.Resize(WebSize(250, 250));
+
+    Document* document =
+        ToLocalFrame(web_view->GetPage()->MainFrame())->GetDocument();
+
+    Element* div1 = document->getElementById("div1");
+    Element* div2 = document->getElementById("div2");
+
+    // Move mouse over div1 should hover div1.
+    WebMouseEvent mouse_move_over_div1(
+        WebInputEvent::kMouseMove, WebFloatPoint(10, 10), WebFloatPoint(10, 10),
+        WebPointerProperties::Button::kNoButton, 0, WebInputEvent::kNoModifiers,
+        TimeTicks::Now().InSeconds());
+    mouse_move_over_div1.SetFrameScale(1);
+    document->GetFrame()->GetEventHandler().HandleMouseMoveEvent(
+        mouse_move_over_div1, Vector<WebMouseEvent>());
+
+    DCHECK(document->HoverElement() == div1);
+
+    // Tap on div2.
+    WebGestureEvent tap_on_div2(WebInputEvent::kGestureTap,
+                                WebInputEvent::kNoModifiers,
+                                WebInputEvent::kTimeStampForTesting);
+    tap_on_div2.SetFrameScale(1);
+    tap_on_div2.x = tap_on_div2.global_x = 10;
+    tap_on_div2.y = tap_on_div2.global_y = 110;
+    tap_on_div2.source_device = kWebGestureDeviceTouchscreen;
+    web_view_helper.WebView()
+        ->MainFrameImpl()
+        ->GetFrame()
+        ->GetEventHandler()
+        .HandleGestureEvent(tap_on_div2);
+
+    Element* expected_hover_element = should_change_hover_state ? div2 : div1;
+    EXPECT_EQ(expected_hover_element, document->HoverElement());
+  }
+};
+
+TEST_F(TapChangeHoverStateTest, TapNotChangeHoverStateOnViewportMetaAndMobile) {
+  RunTest(true, true, false);
+}
+
+TEST_F(TapChangeHoverStateTest, TapChangeHoverStateOnNoViewportMetaAndMobile) {
+  RunTest(true, false, true);
+}
+
+TEST_F(TapChangeHoverStateTest, TapChangeHoverStateOnViewportMetaAndDesktop) {
+  RunTest(false, true, true);
+}
+
 TEST_F(WebFrameTest,
        CustomScrollbarInOverlayScrollbarThemeWillNotCauseDCHECKFails) {
   RegisterMockedHttpURLLoad(
       "custom-scrollbar-dcheck-failed-when-paint-scroll-corner.html");
   FrameTestHelpers::WebViewHelper web_view_helper;
   WebViewBase* web_view = web_view_helper.InitializeAndLoad(
       base_url_ +
       "custom-scrollbar-dcheck-failed-when-paint-scroll-corner.html");
 
   web_view_helper.Resize(WebSize(200, 200));
@@ skipping 531 matching lines @@
     if (obj->IsText()) {
       LayoutText* layout_text = ToLayoutText(obj);
       text = layout_text->GetText();
       break;
     }
   }
   EXPECT_EQ("foo alt", text.Utf8());
 }
 
 }  // namespace blink