sync/api/attachments/attachment_service_impl.h - Issue 293143002: Add AttachmentDownloader interface, change signature of AttachmentStore::Read

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/api/attachments/attachment_service_impl.h

Issue 293143002: Add AttachmentDownloader interface, change signature of AttachmentStore::Read (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes after feedback from Nick Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/api/attachments/attachment_service_impl.h

diff --git a/sync/api/attachments/attachment_service_impl.h b/sync/api/attachments/attachment_service_impl.h

index aa991103f4fadadf349da63e4e079796928610db..dbb1b530ae988d79548450d1e1a6ecae7a9aaaaf 100644

--- a/sync/api/attachments/attachment_service_impl.h

+++ b/sync/api/attachments/attachment_service_impl.h

@@ -45,7 +45,8 @@ class SYNC_EXPORT AttachmentServiceImpl : public AttachmentService,

private:

void ReadDone(const GetOrDownloadCallback& callback,

const AttachmentStore::Result& result,

- scoped_ptr<AttachmentMap> attachments);

+ scoped_ptr<AttachmentMap> attachments,

+ scoped_ptr<AttachmentIdList> unavailable_attachment_ids);

void DropDone(const DropCallback& callback,

const AttachmentStore::Result& result);

void WriteDone(const StoreCallback& callback,

« no previous file with comments | « sync/api/attachments/attachment_downloader.cc ('k') | sync/api/attachments/attachment_service_impl.cc » ('j') | no next file with comments »