sync/api/attachments/attachment_uploader.h - Issue 293143002: Add AttachmentDownloader interface, change signature of AttachmentStore::Read

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/api/attachments/attachment_uploader.h

Issue 293143002: Add AttachmentDownloader interface, change signature of AttachmentStore::Read (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sync/api/attachments/attachment_downloader.h ('K') | « sync/api/attachments/attachment_store.h ('k') | sync/internal_api/attachments/fake_attachment_store.cc » ('j') | sync/internal_api/attachments/fake_attachment_store_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/api/attachments/attachment_uploader.h

diff --git a/sync/api/attachments/attachment_uploader.h b/sync/api/attachments/attachment_uploader.h

index 325a9e7d1f5836547dcc02a43df836880d240256..12fe1a308ad0fbe0438df55ac9feed66f8e22cb6 100644

--- a/sync/api/attachments/attachment_uploader.h

+++ b/sync/api/attachments/attachment_uploader.h

@@ -8,7 +8,6 @@

#include "base/basictypes.h"

#include "base/callback.h"

#include "base/memory/scoped_ptr.h"

-#include "base/memory/weak_ptr.h"

#include "sync/api/attachments/attachment.h"

#include "sync/base/sync_export.h"

@@ -36,7 +35,7 @@ class SYNC_EXPORT AttachmentUploader {

// or otherwise).

// |callback| will receive an UploadResult code and an updated AttachmentId

- // |containing the server address of the newly uploaded attachment.

+ // containing the server address of the newly uploaded attachment.

virtual void UploadAttachment(const Attachment& attachment,

const UploadCallback& callback) = 0;

};