extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc - Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/extensions/notifications_native_handler.cc ('K') | « extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc ('k') | extensions/renderer/i18n_custom_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc

diff --git a/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc b/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc

index c27ded7fa9bb86d6cdbeab43c28935b32d30aca1..cd38e4c2d639b957d79d493c9a459de09cfeeab0 100644

--- a/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc

+++ b/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc

@@ -268,10 +268,8 @@ void MimeHandlerViewContainer::PostMessageFromValue(

v8::Isolate* isolate = v8::Isolate::GetCurrent();

v8::HandleScope handle_scope(isolate);

v8::Context::Scope context_scope(frame->MainWorldScriptContext());

- std::unique_ptr<content::V8ValueConverter> converter(

- content::V8ValueConverter::create());

- PostMessage(isolate,

- converter->ToV8Value(&message, frame->MainWorldScriptContext()));

+ PostMessage(isolate, content::V8ValueConverter::Create()->ToV8Value(

+ &message, frame->MainWorldScriptContext()));

}

void MimeHandlerViewContainer::OnCreateMimeHandlerViewGuestACK(