Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: extensions/renderer/api_event_handler.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api_event_handler.cc
diff --git a/extensions/renderer/api_event_handler.cc b/extensions/renderer/api_event_handler.cc
index 7c37c60d6cd0a93a64d48f84f3a0f1ef7ed883e4..e85441e97dff17df547ad6165a62480ceb94bfed 100644
--- a/extensions/renderer/api_event_handler.cc
+++ b/extensions/renderer/api_event_handler.cc
@@ -216,8 +216,8 @@ void APIEventHandler::FireEventInContext(const std::string& event_name,
// Note: since we only convert the arguments once, if a listener modifies an
// object (including an array), other listeners will see that modification.
// TODO(devlin): This is how it's always been, but should it be?
- std::unique_ptr<content::V8ValueConverter> converter(
- content::V8ValueConverter::create());
+ std::unique_ptr<content::V8ValueConverter> converter =
+ content::V8ValueConverter::Create();
auto massager_iter = data->massagers.find(event_name);
if (massager_iter == data->massagers.end()) {

Powered by Google App Engine
This is Rietveld 408576698