Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/guest_view/mime_handler_view/mime_handler_view_con tainer.h" 5 #include "extensions/renderer/guest_view/mime_handler_view/mime_handler_view_con tainer.h"
6 6
7 #include <map> 7 #include <map>
8 #include <set> 8 #include <set>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 261
262 void MimeHandlerViewContainer::PostMessageFromValue( 262 void MimeHandlerViewContainer::PostMessageFromValue(
263 const base::Value& message) { 263 const base::Value& message) {
264 blink::WebFrame* frame = render_frame()->GetWebFrame(); 264 blink::WebFrame* frame = render_frame()->GetWebFrame();
265 if (!frame) 265 if (!frame)
266 return; 266 return;
267 267
268 v8::Isolate* isolate = v8::Isolate::GetCurrent(); 268 v8::Isolate* isolate = v8::Isolate::GetCurrent();
269 v8::HandleScope handle_scope(isolate); 269 v8::HandleScope handle_scope(isolate);
270 v8::Context::Scope context_scope(frame->MainWorldScriptContext()); 270 v8::Context::Scope context_scope(frame->MainWorldScriptContext());
271 std::unique_ptr<content::V8ValueConverter> converter( 271 PostMessage(isolate, content::V8ValueConverter::Create()->ToV8Value(
272 content::V8ValueConverter::create()); 272 &message, frame->MainWorldScriptContext()));
273 PostMessage(isolate,
274 converter->ToV8Value(&message, frame->MainWorldScriptContext()));
275 } 273 }
276 274
277 void MimeHandlerViewContainer::OnCreateMimeHandlerViewGuestACK( 275 void MimeHandlerViewContainer::OnCreateMimeHandlerViewGuestACK(
278 int element_instance_id) { 276 int element_instance_id) {
279 DCHECK_NE(this->element_instance_id(), guest_view::kInstanceIDNone); 277 DCHECK_NE(this->element_instance_id(), guest_view::kInstanceIDNone);
280 DCHECK_EQ(this->element_instance_id(), element_instance_id); 278 DCHECK_EQ(this->element_instance_id(), element_instance_id);
281 279
282 if (!render_frame()) 280 if (!render_frame())
283 return; 281 return;
284 282
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 if (!render_frame()) 325 if (!render_frame())
328 return; 326 return;
329 327
330 render_frame()->Send( 328 render_frame()->Send(
331 new ExtensionsGuestViewHostMsg_CreateMimeHandlerViewGuest( 329 new ExtensionsGuestViewHostMsg_CreateMimeHandlerViewGuest(
332 render_frame()->GetRoutingID(), view_id_, element_instance_id(), 330 render_frame()->GetRoutingID(), view_id_, element_instance_id(),
333 element_size_)); 331 element_size_));
334 } 332 }
335 333
336 } // namespace extensions 334 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698