third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h - Issue 2931363002: [LayoutNG] More precise checks for empty inline and add test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h

Issue 2931363002: [LayoutNG] More precise checks for empty inline and add test (Closed)

Patch Set: ikilpatrick review Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc ('k') | third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h

index ea695dd8c52df84e18f246bd568c0be782810d43..1533e161bc8e2e377568ca2fb990935d961bc2af 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h

@@ -48,6 +48,9 @@ struct CORE_EXPORT NGInlineItemResult {

LayoutUnit borders_paddings_block_start;

LayoutUnit borders_paddings_block_end;

+ // Create a box when the box is empty, for open/close tags.

+ unsigned needs_box_when_empty : 1;

// Inside of this is not breakable.

// Used only during line breaking.

unsigned no_break_opportunities_inside : 1;