Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8213)

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 2931243002: Unframe chrome://extensions as it's the last (and only) uber item (Closed)
Patch Set: merge Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
index 2d56788bd7adea872525edc1c1065b79ac6c21cc..8b8d0b371db761dce952ffa4ae3681ce6f13ca1b 100644
--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
@@ -32,7 +32,6 @@
#include "chrome/browser/ui/webui/flags_ui.h"
#include "chrome/browser/ui/webui/flash_ui.h"
#include "chrome/browser/ui/webui/gcm_internals_ui.h"
-#include "chrome/browser/ui/webui/help/help_ui.h"
#include "chrome/browser/ui/webui/identity_internals_ui.h"
#include "chrome/browser/ui/webui/instant_ui.h"
#include "chrome/browser/ui/webui/interstitials/interstitial_ui.h"
@@ -125,7 +124,6 @@
#include "chrome/browser/ui/webui/ntp/new_tab_ui.h"
#include "chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_ui.h"
#include "chrome/browser/ui/webui/system_info_ui.h"
-#include "chrome/browser/ui/webui/uber/uber_ui.h"
#endif
#if defined(OS_CHROMEOS)
@@ -414,9 +412,6 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
::switches::MdFeedbackEnabled()) {
return &NewWebUI<MdFeedbackUI>;
}
- // Help is implemented with native UI elements on Android.
- if (url.host_piece() == chrome::kChromeUIHelpFrameHost)
- return &NewWebUI<HelpUI>;
// Identity API is not available on Android.
if (url.host_piece() == chrome::kChromeUIIdentityInternalsHost)
return &NewWebUI<IdentityInternalsUI>;
@@ -427,24 +422,14 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
url.host_piece() == chrome::kChromeUIMdSettingsHost) {
return &NewWebUI<settings::MdSettingsUI>;
}
- // If the material design extensions page is enabled, it gets its own host.
- // Otherwise, it's handled by the uber settings page.
- if (url.host_piece() == chrome::kChromeUIExtensionsHost &&
- base::FeatureList::IsEnabled(features::kMaterialDesignExtensions)) {
+ if (url.host_piece() == chrome::kChromeUIExtensionsHost)
return &NewWebUI<extensions::ExtensionsUI>;
- }
if (url.host_piece() == chrome::kChromeUIHistoryHost)
return &NewWebUI<MdHistoryUI>;
if (url.host_piece() == chrome::kChromeUISyncFileSystemInternalsHost)
return &NewWebUI<SyncFileSystemInternalsUI>;
if (url.host_piece() == chrome::kChromeUISystemInfoHost)
return &NewWebUI<SystemInfoUI>;
- // Uber frame is not used on Android.
- if (url.host_piece() == chrome::kChromeUIUberFrameHost)
- return &NewWebUI<UberFrameUI>;
- // Uber page is not used on Android.
- if (url.host_piece() == chrome::kChromeUIUberHost)
- return &NewWebUI<UberUI>;
#endif // !defined(OS_ANDROID)
#if defined(OS_WIN)
if (url.host_piece() == chrome::kChromeUIConflictsHost)

Powered by Google App Engine
This is Rietveld 408576698