Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5498)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 2931243002: Unframe chrome://extensions as it's the last (and only) uber item (Closed)
Patch Set: merge Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index 235c75809788a16f6dc75e27e59c8ee0566614f2..5582d587065f5b0213acbdab79d5b9088a3d15e1 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -984,7 +984,7 @@ cr.define('extensions', function() {
// Add the options query string. Corner case: the 'options' query string
// will clobber the 'id' query string if the options link is clicked when
// 'id' is in the URL, or if both query strings are in the URL.
- uber.replaceState({}, '?options=' + extensionId);
+ window.history.replaceState({}, '', '/?options=' + extensionId);
Devlin 2017/06/12 14:17:18 why window.history instead of history? (I can't f
Dan Beam 2017/06/12 23:13:12 it's because of the way it's externed: https://git
Devlin 2017/06/13 18:04:21 Ah, interesting...
Dan Beam 2017/06/13 18:15:16 Acknowledged.
var overlay = extensions.ExtensionOptionsOverlay.getInstance();
var shownCallback = function() {
@@ -1003,7 +1003,7 @@ cr.define('extensions', function() {
$('overlay').removeEventListener('cancelOverlay', f);
// Remove the options query string.
- uber.replaceState({}, '');
+ window.history.replaceState({}, '', '/');
});
// TODO(dbeam): why do we need to focus <extensionoptions> before and
« no previous file with comments | « chrome/browser/resources/extensions/compiled_resources2.gyp ('k') | chrome/browser/resources/extensions/extensions.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698