Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3078)

Unified Diff: chrome/browser/browser_about_handler.cc

Issue 2931243002: Unframe chrome://extensions as it's the last (and only) uber item (Closed)
Patch Set: policy_android.css Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browser_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_about_handler.cc
diff --git a/chrome/browser/browser_about_handler.cc b/chrome/browser/browser_about_handler.cc
index 3601b8158c4d0616a22d0529f96daed962d466ba..9c61033eb0f2ec9eea28c25301c1a7cb0a66caef 100644
--- a/chrome/browser/browser_about_handler.cc
+++ b/chrome/browser/browser_about_handler.cc
@@ -71,24 +71,16 @@ bool WillHandleBrowserAboutURL(GURL* url,
// Replace sync with sync-internals (for legacy reasons).
} else if (host == chrome::kChromeUISyncHost) {
host = chrome::kChromeUISyncInternalsHost;
- // Redirect chrome://extensions.
+// Redirect chrome://extensions, chrome://extensions-frame, and
+// chrome://settings/extensions all to chrome://extensions and forward path.
#if BUILDFLAG(ENABLE_EXTENSIONS)
- } else if (host == chrome::kChromeUIExtensionsHost) {
- // If the material design extensions page is enabled, it gets its own host.
- // Otherwise, it's handled by the uber settings page.
- if (base::FeatureList::IsEnabled(features::kMaterialDesignExtensions)) {
- host = chrome::kChromeUIExtensionsHost;
- path = url->path();
- } else {
- host = chrome::kChromeUIUberHost;
- path = chrome::kChromeUIExtensionsHost + url->path();
- }
- // Redirect chrome://settings/extensions (legacy URL).
- } else if (host == chrome::kChromeUISettingsHost &&
- url->path() ==
- std::string("/") + chrome::kDeprecatedExtensionsSubPage) {
- host = chrome::kChromeUIUberHost;
- path = chrome::kChromeUIExtensionsHost;
+ } else if (host == chrome::kChromeUIExtensionsHost ||
+ host == chrome::kChromeUIExtensionsFrameHost ||
+ (host == chrome::kChromeUISettingsHost &&
+ url->path() ==
+ std::string("/") + chrome::kDeprecatedExtensionsSubPage)) {
+ host = chrome::kChromeUIExtensionsHost;
+ path = url->path();
#endif // BUILDFLAG(ENABLE_EXTENSIONS)
} else if (host == chrome::kChromeUIHistoryHost) {
// Redirect chrome://history.
« no previous file with comments | « no previous file | chrome/browser/browser_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698