chrome/browser/resources/extensions/extensions.html - Issue 2931243002: Unframe chrome://extensions as it's the last (and only) uber item - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(2580)

My Issues | Starred Open | Closed | All

Unified Diff: chrome/browser/resources/extensions/extensions.html

Issue 2931243002: Unframe chrome://extensions as it's the last (and only) uber item (Closed)

Patch Set: devlin Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « chrome/browser/resources/extensions/extension_list.js ('k') | chrome/browser/resources/extensions/extensions.js » ('j') | chrome/browser/resources/local_discovery/local_discovery.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/extensions/extensions.html

diff --git a/chrome/browser/resources/extensions/extensions.html b/chrome/browser/resources/extensions/extensions.html

index 72a4c4c9515b94182669e47d7bcabbffd7e36ad5..7ed15c83bb5e8544260676647bbbeb46077a397d 100644

--- a/chrome/browser/resources/extensions/extensions.html

+++ b/chrome/browser/resources/extensions/extensions.html

@@ -1,7 +1,8 @@

<!doctype html>

-<html i18n-values="dir:textdirection;lang:language">

+<html dir="$i18n{textdirection}" lang="$i18n{language}">

<head>

<meta charset="utf-8">

+<title>$i18n{extensionSettings}</title>

<link rel="stylesheet" href="extensions.css">

<link rel="stylesheet" href="extension_commands_overlay.css">

@@ -49,10 +50,10 @@

<script src="chrome://resources/js/cr/ui/list.js"></script>

</if>

-<script src="chrome://extensions-frame/extensions.js"></script>

+<script src="chrome://extensions/extensions.js"></script>

</head>

-<body class="uber-frame">

+<body>

<div id="overlay" class="overlay" hidden>

<include src="extension_commands_overlay.html">

@@ -273,7 +274,7 @@

</div>

-<script src="chrome://extensions-frame/strings.js"></script>

+<script src="chrome://extensions/strings.js"></script>

<script src="chrome://resources/js/i18n_template.js"></script>

</body>

« no previous file with comments | « chrome/browser/resources/extensions/extension_list.js ('k') | chrome/browser/resources/extensions/extensions.js » ('j') | chrome/browser/resources/local_discovery/local_discovery.html » ('J')

Powered by Google App Engine

This is Rietveld 408576698