Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 293123010: Add a field trial to disable deferred committing of cookie changes (Closed)

Created:
6 years, 7 months ago by tburkard
Modified:
6 years, 7 months ago
Reviewers:
davidben
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, davidben+watch_chromium.org
Visibility:
Public.

Description

Add a field trial to disable deferred committing of cookie changes by prerender. This can be used to emergency disable the feature, or to do comparisons of other metrics. R=davidben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272824

Patch Set 1 #

Patch Set 2 : sync #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -15 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 2 1 chunk +13 lines, -9 lines 0 comments Download
M chrome/browser/prerender/prerender_field_trial.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_field_trial.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 2 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
tburkard
6 years, 7 months ago (2014-05-23 13:29:54 UTC) #1
davidben
lgtm
6 years, 7 months ago (2014-05-23 18:02:09 UTC) #2
tburkard
The CQ bit was checked by tburkard@chromium.org
6 years, 7 months ago (2014-05-23 20:08:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tburkard@chromium.org/293123010/1
6 years, 7 months ago (2014-05-23 20:09:23 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-24 00:32:54 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-24 00:42:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/19582)
6 years, 7 months ago (2014-05-24 00:42:43 UTC) #7
tburkard
The CQ bit was checked by tburkard@chromium.org
6 years, 7 months ago (2014-05-24 05:52:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tburkard@chromium.org/293123010/20001
6 years, 7 months ago (2014-05-24 05:52:45 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-24 08:09:07 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-24 08:15:24 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77389)
6 years, 7 months ago (2014-05-24 08:15:25 UTC) #12
tburkard
The CQ bit was checked by tburkard@chromium.org
6 years, 7 months ago (2014-05-26 09:39:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tburkard@chromium.org/293123010/30001
6 years, 7 months ago (2014-05-26 09:40:53 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 11:06:03 UTC) #15
tburkard
6 years, 7 months ago (2014-05-26 15:46:32 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 manually as r272824 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698