chrome/browser/media/webrtc_browsertest_base.cc - Issue 293123009: Cleaned up WebRTC browser test js, removed unneeded stuff.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc_browsertest_base.cc

Issue 293123009: Cleaned up WebRTC browser test js, removed unneeded stuff. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/chrome_webrtc_browsertest.cc ('k') | chrome/test/data/webrtc/getusermedia.js » ('j') | chrome/test/data/webrtc/manual/peerconnection.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/webrtc_browsertest_base.cc

diff --git a/chrome/browser/media/webrtc_browsertest_base.cc b/chrome/browser/media/webrtc_browsertest_base.cc

index f469ff960bd57cbd7f071c57f156475bb659d5a7..084e953ea5841051b9f7a7fdf74d97a78552267d 100644

--- a/chrome/browser/media/webrtc_browsertest_base.cc

+++ b/chrome/browser/media/webrtc_browsertest_base.cc

@@ -21,24 +21,24 @@

#include "net/test/embedded_test_server/embedded_test_server.h"

const char WebRtcTestBase::kAudioVideoCallConstraints[] =

- "'{audio: true, video: true}'";

+ "{audio: true, video: true}";

const char WebRtcTestBase::kAudioVideoCallConstraintsQVGA[] =

- "'{audio: true, video: {mandatory: {minWidth: 320, maxWidth: 320, "

- " minHeight: 240, maxHeight: 240}}}'";

+ "{audio: true, video: {mandatory: {minWidth: 320, maxWidth: 320, "

+ " minHeight: 240, maxHeight: 240}}}";

const char WebRtcTestBase::kAudioVideoCallConstraints360p[] =

- "'{audio: true, video: {mandatory: {minWidth: 640, maxWidth: 640, "

- " minHeight: 360, maxHeight: 360}}}'";

+ "{audio: true, video: {mandatory: {minWidth: 640, maxWidth: 640, "

+ " minHeight: 360, maxHeight: 360}}}";

const char WebRtcTestBase::kAudioVideoCallConstraintsVGA[] =

- "'{audio: true, video: {mandatory: {minWidth: 640, maxWidth: 640, "

- " minHeight: 480, maxHeight: 480}}}'";

+ "{audio: true, video: {mandatory: {minWidth: 640, maxWidth: 640, "

+ " minHeight: 480, maxHeight: 480}}}";

const char WebRtcTestBase::kAudioVideoCallConstraints720p[] =

- "'{audio: true, video: {mandatory: {minWidth: 1280, maxWidth: 1280, "

- " minHeight: 720, maxHeight: 720}}}'";

+ "{audio: true, video: {mandatory: {minWidth: 1280, maxWidth: 1280, "

+ " minHeight: 720, maxHeight: 720}}}";

const char WebRtcTestBase::kAudioVideoCallConstraints1080p[] =

- "'{audio: true, video: {mandatory: {minWidth: 1920, maxWidth: 1920, "

- " minHeight: 1080, maxHeight: 1080}}}'";

-const char WebRtcTestBase::kAudioOnlyCallConstraints[] = "'{audio: true}'";

-const char WebRtcTestBase::kVideoOnlyCallConstraints[] = "'{video: true}'";

+ "{audio: true, video: {mandatory: {minWidth: 1920, maxWidth: 1920, "

+ " minHeight: 1080, maxHeight: 1080}}}";

+const char WebRtcTestBase::kAudioOnlyCallConstraints[] = "{audio: true}";

+const char WebRtcTestBase::kVideoOnlyCallConstraints[] = "{video: true}";

const char WebRtcTestBase::kFailedWithPermissionDeniedError[] =

"failed-with-error-PermissionDeniedError";

const char WebRtcTestBase::kFailedWithPermissionDismissedError[] =