Cleaned up WebRTC browser test js, removed unneeded stuff.

Cleaned up WebRTC browser test js, removed unneeded stuff.

This patch merges message_handling.js and jsep01_call.js. The
distinction isn't useful anymore since we used to support multiple
signaling bases like ROAP, we don't anymore. Besides, message_handling
had evolved to practically be the public interface to the test C++,
so this patch makes this role more explicit.

Also the code used to be very flexible to support all kinds of
permutations that we need to do in the manual test page, but since that
code has moved off on its own we can eliminate the flexibility and
thereby greatly simplify the code.

Also improves the error reporting by including the js stack trace
when there's a test failure.

BUG=375240
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272994

[phoglund_chromium, 2014-05-23 11:15:33]

kjellander: main review
tommi: owner stamp

https://codereview.chromium.org/293123009/diff/1/chrome/test/data/webrtc/manu...
File chrome/test/data/webrtc/manual/peerconnection.html (right):

https://codereview.chromium.org/293123009/diff/1/chrome/test/data/webrtc/manu...
chrome/test/data/webrtc/manual/peerconnection.html:7: <script
src="peerconnection_manual.js"></script>
Renamed this one to avoid confusion with the new peerconnection.js.

[phoglund_chromium, 2014-05-26 14:03:31]

ping

[kjellander_chromium, 2014-05-26 14:30:46]

Sorry, I missed this one somehow. 

lgtm and very nice cleanup!
Ideally we should try to get rid of document.getElementById calls in the .js
code if possible, but that can be done in a future CL.

https://codereview.chromium.org/293123009/diff/20001/chrome/test/data/webrtc/...
File chrome/test/data/webrtc/getusermedia.js (right):

https://codereview.chromium.org/293123009/diff/20001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/getusermedia.js:48: * @param {!object} constraints
Defines what to be requested, with mandatory
nit: Object starting with uppercase according to
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...

same below.

[phoglund_chromium, 2014-05-27 09:29:44]

https://codereview.chromium.org/293123009/diff/20001/chrome/test/data/webrtc/...
File chrome/test/data/webrtc/getusermedia.js (right):

https://codereview.chromium.org/293123009/diff/20001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/getusermedia.js:48: * @param {!object} constraints
Defines what to be requested, with mandatory
On 2014/05/26 14:30:47, kjellander wrote:
> nit: Object starting with uppercase according to
>
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone...
> 
> same below.

Done.

[phoglund_chromium, 2014-05-27 09:29:49]

The CQ bit was checked by phoglund@chromium.org

[commit-bot: I haz the power, 2014-05-27 09:30:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/phoglund@chromium.org/293123009/40001

[commit-bot: I haz the power, 2014-05-27 11:19:55]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-27 11:23:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 11:23:56]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[tommi (sloooow) - chröme, 2014-05-27 11:27:38]

rs lgtm

[phoglund_chromium, 2014-05-27 12:08:28]

The CQ bit was checked by phoglund@chromium.org

[commit-bot: I haz the power, 2014-05-27 12:08:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/phoglund@chromium.org/293123009/60001

[commit-bot: I haz the power, 2014-05-27 14:35:56]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-27 17:41:04]

Change committed as 272994