Issue 2931153002: Support field initializers and static/top-level fields in compile_with_dill_test

Issue 2931153002: Support field initializers and static/top-level fields in compile_with_dill_test (Closed)

Created:
3 years, 6 months ago by Johnni Winther

Modified:
3 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang), Emily Fortuna

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Support field initializers and static/top-level fields in compile_with_dill_test + a String literal! R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/44258bc8eb1e95a1479ce4017049d3b15202dcac

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -33 lines)			Patch
M	pkg/compiler/lib/src/kernel/element_map.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/kernel/element_map_impl.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder_kernel.dart	View	1 chunk	+10 lines, -20 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	tests/compiler/dart2js/kernel/compile_from_dill_test.dart	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 7 (3 generated)

Emily Fortuna

On 2017/06/09 20:03:01, Emily Fortuna wrote: > lgtm > > 🎉🎉🍻🎈🎉 (those are supposed to ...

3 years, 6 months ago (2017-06-09 20:03:19 UTC) #5

Johnni Winther

3 years, 6 months ago (2017-06-12 08:01:37 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
44258bc8eb1e95a1479ce4017049d3b15202dcac (presubmit successful).