third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js - Issue 2931143003: DevTools: make debugger's rawLocationToUILocation return nullable type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 2931143003: DevTools: make debugger's rawLocationToUILocation return nullable type (Closed)

Patch Set: add test Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/inspector/bindings/livelocation-main-frame-navigated-expected.txt ('K') | « third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

index 051298d8556eaccc8c86f092f5452dd43a68203c..e72312d9f464337e250eddbf21d9e207af4eafb2 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

@@ -862,7 +862,7 @@ Sources.JavaScriptSourceFrame = class extends SourceFrame.UISourceCodeFrame {

var functionUILocation = Bindings.debuggerWorkspaceBinding.rawLocationToUILocation(

/** @type {!SDK.DebuggerModel.Location} */ (callFrame.functionLocation()));

var executionUILocation = Bindings.debuggerWorkspaceBinding.rawLocationToUILocation(callFrame.location());

- if (functionUILocation.uiSourceCode !== this._debuggerSourceCode ||

+ if (!functionUILocation || !executionUILocation || functionUILocation.uiSourceCode !== this._debuggerSourceCode ||

executionUILocation.uiSourceCode !== this._debuggerSourceCode) {

this._clearValueWidgets();

return;