Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2931143003: DevTools: make debugger's rawLocationToUILocation return nullable type (Closed)
Patch Set: add test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1141 matching lines...) Expand 10 before | Expand all | Expand 10 after
1152 Sources.SourcesPanel.DebuggerLocationRevealer = class { 1152 Sources.SourcesPanel.DebuggerLocationRevealer = class {
1153 /** 1153 /**
1154 * @override 1154 * @override
1155 * @param {!Object} rawLocation 1155 * @param {!Object} rawLocation
1156 * @param {boolean=} omitFocus 1156 * @param {boolean=} omitFocus
1157 * @return {!Promise} 1157 * @return {!Promise}
1158 */ 1158 */
1159 reveal(rawLocation, omitFocus) { 1159 reveal(rawLocation, omitFocus) {
1160 if (!(rawLocation instanceof SDK.DebuggerModel.Location)) 1160 if (!(rawLocation instanceof SDK.DebuggerModel.Location))
1161 return Promise.reject(new Error('Internal error: not a debugger location') ); 1161 return Promise.reject(new Error('Internal error: not a debugger location') );
1162 Sources.SourcesPanel.instance().showUILocation( 1162 var uiLocation = Bindings.debuggerWorkspaceBinding.rawLocationToUILocation(r awLocation);
1163 Bindings.debuggerWorkspaceBinding.rawLocationToUILocation(rawLocation), omitFocus); 1163 if (!uiLocation)
1164 return Promise.resolve();
1165 Sources.SourcesPanel.instance().showUILocation(uiLocation, omitFocus);
1164 return Promise.resolve(); 1166 return Promise.resolve();
1165 } 1167 }
1166 }; 1168 };
1167 1169
1168 /** 1170 /**
1169 * @implements {Common.Revealer} 1171 * @implements {Common.Revealer}
1170 * @unrestricted 1172 * @unrestricted
1171 */ 1173 */
1172 Sources.SourcesPanel.UISourceCodeRevealer = class { 1174 Sources.SourcesPanel.UISourceCodeRevealer = class {
1173 /** 1175 /**
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
1301 */ 1303 */
1302 willHide() { 1304 willHide() {
1303 UI.inspectorView.setDrawerMinimized(false); 1305 UI.inspectorView.setDrawerMinimized(false);
1304 setImmediate(() => Sources.SourcesPanel.updateResizerAndSidebarButtons(Sourc es.SourcesPanel.instance())); 1306 setImmediate(() => Sources.SourcesPanel.updateResizerAndSidebarButtons(Sourc es.SourcesPanel.instance()));
1305 } 1307 }
1306 1308
1307 _showViewInWrapper() { 1309 _showViewInWrapper() {
1308 this._view.show(this.element); 1310 this._view.show(this.element);
1309 } 1311 }
1310 }; 1312 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698