|
Simplify animation/transition parsing slightly
This patch simplifies parsing CSS animations and transitions slightly by
making us only return CSSValueLists from the parser, including when we
only have a single value in the list. This was probably done differently
in the past (with single values not being wrapped in a CSSValueList) as
premature optimisation, which adds needless complexity to the code. Note
this changes the foo.style.getPropertyCSSValue output slightly.
I've also made BisonCSSParser::parseAnimationTimingFunctionValue return
a single (non-valuelist-wrapped) CSSValue which isn't initial or inherit
to better match the intention of the callers.
R=alancutter,dstockwell
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175153
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+197 lines, -300 lines) |
Patch |
 |
M |
LayoutTests/fast/css/getFloatValueForUnit.html
|
View
|
1
2
|
1 chunk |
+34 lines, -38 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/css/getFloatValueForUnit-expected.txt
|
View
|
1
2
|
1 chunk |
+29 lines, -29 lines |
0 comments
|
Download
|
 |
M |
Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
|
View
|
|
1 chunk |
+2 lines, -6 lines |
0 comments
|
Download
|
 |
M |
Source/core/animation/EffectInput.cpp
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/animation/TimingInput.cpp
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
Source/core/animation/css/CSSAnimations.cpp
|
View
|
1
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
Source/core/css/parser/BisonCSSParser-in.cpp
|
View
|
1
|
1 chunk |
+7 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/core/css/parser/CSSPropertyParser.h
|
View
|
1
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
Source/core/css/parser/CSSPropertyParser.cpp
|
View
|
1
|
10 chunks |
+117 lines, -212 lines |
0 comments
|
Download
|
 |
M |
Source/core/css/resolver/CSSToStyleMap.cpp
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
Total messages: 8 (0 generated)
|