Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 293113007: Simplify animation/transition parsing slightly (Closed)

Created:
6 years, 7 months ago by Timothy Loh
Modified:
6 years, 6 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-reviews-css, rune+blink, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, rwlbuis, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Simplify animation/transition parsing slightly This patch simplifies parsing CSS animations and transitions slightly by making us only return CSSValueLists from the parser, including when we only have a single value in the list. This was probably done differently in the past (with single values not being wrapped in a CSSValueList) as premature optimisation, which adds needless complexity to the code. Note this changes the foo.style.getPropertyCSSValue output slightly. I've also made BisonCSSParser::parseAnimationTimingFunctionValue return a single (non-valuelist-wrapped) CSSValue which isn't initial or inherit to better match the intention of the callers. R=alancutter,dstockwell Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175153

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -300 lines) Patch
M LayoutTests/fast/css/getFloatValueForUnit.html View 1 2 1 chunk +34 lines, -38 lines 0 comments Download
M LayoutTests/fast/css/getFloatValueForUnit-expected.txt View 1 2 1 chunk +29 lines, -29 lines 0 comments Download
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 chunk +2 lines, -6 lines 0 comments Download
M Source/core/animation/EffectInput.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/animation/TimingInput.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 1 chunk +7 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 10 chunks +117 lines, -212 lines 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Timothy Loh
6 years, 7 months ago (2014-05-26 03:30:27 UTC) #1
dstockwell
lgtm
6 years, 6 months ago (2014-05-29 22:17:38 UTC) #2
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 6 months ago (2014-05-30 03:50:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/293113007/40001
6 years, 6 months ago (2014-05-30 03:53:19 UTC) #4
Paweł Hajdan Jr.
The CQ bit was unchecked by phajdan.jr@chromium.org
6 years, 6 months ago (2014-05-30 16:23:50 UTC) #5
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 6 months ago (2014-05-30 16:28:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/293113007/40001
6 years, 6 months ago (2014-05-30 16:31:02 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 17:12:53 UTC) #8
Message was sent while issue was closed.
Change committed as 175153

Powered by Google App Engine
This is Rietveld 408576698