Provide diagnostic messages about netrc failures.

Provide diagnostic messages about netrc failures.

BUG=376546
R=mmoss@chromium.org,agable@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=273002

[Michael Moss, 2014-05-22 23:57:03]

lgtm

https://codereview.chromium.org/293113005/diff/1/gerrit_util.py
File gerrit_util.py (right):

https://codereview.chromium.org/293113005/diff/1/gerrit_util.py#newcode25
gerrit_util.py:25: _netrc_file = os.path.join(os.environ['HOME'], _netrc_file)
You mean the netrc module doesn't know how to do this already? :/

https://codereview.chromium.org/293113005/diff/1/gerrit_util.py#newcode32
gerrit_util.py:32: _netrc_stat = os.stat(_netrc_file)
FWIW, NetrcParseError.filename

https://codereview.chromium.org/293113005/diff/1/gerrit_util.py#newcode39
gerrit_util.py:39: 'error.' % _netrc_file)
If you print the exception, it will give a bit more detail about what failed to
parse.

[szager1, 2014-05-23 08:52:17]

https://codereview.chromium.org/293113005/diff/1/gerrit_util.py
File gerrit_util.py (right):

https://codereview.chromium.org/293113005/diff/1/gerrit_util.py#newcode25
gerrit_util.py:25: _netrc_file = os.path.join(os.environ['HOME'], _netrc_file)
On 2014/05/22 23:57:03, Michael Moss wrote:
> You mean the netrc module doesn't know how to do this already? :/

I actually looked through the netrc.py code, on both linux and win, and it
doesn't know this already.  Weird, huh?

https://codereview.chromium.org/293113005/diff/1/gerrit_util.py#newcode32
gerrit_util.py:32: _netrc_stat = os.stat(_netrc_file)
On 2014/05/22 23:57:03, Michael Moss wrote:
> FWIW, NetrcParseError.filename

Done.

https://codereview.chromium.org/293113005/diff/1/gerrit_util.py#newcode39
gerrit_util.py:39: 'error.' % _netrc_file)
On 2014/05/22 23:57:03, Michael Moss wrote:
> If you print the exception, it will give a bit more detail about what failed
to
> parse.

Actually, I think the right thing to do is to re-raise here.

[Michael Moss, 2014-05-23 15:28:44]

lgtm

[szager1, 2014-05-27 18:53:27]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2014-05-27 18:53:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/szager@chromium.org/293113005/60001

[commit-bot: I haz the power, 2014-05-27 18:55:56]

Change committed as 273002