Extract colors from wallpaper and dynamically update login screen overlay

chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h"
 
 #include <utility>
 
 #include "ash/ash_constants.h"
 #include "ash/public/cpp/shelf_types.h"
@@ skipping 186 matching lines @@
 void SetKnownUserWallpaperFilesId(
     const AccountId& account_id,
     const wallpaper::WallpaperFilesId& wallpaper_files_id) {
   user_manager::known_user::SetStringPref(account_id, kWallpaperFilesId,
                                           wallpaper_files_id.id());
 }
 
 // A helper to set the wallpaper image for Classic Ash and Mash.
 void SetWallpaper(const gfx::ImageSkia& image,
                   wallpaper::WallpaperLayout layout) {
+  WallpaperManager::Get()->CalculateProminentColor(image);
   if (ash_util::IsRunningInMash()) {
     // In mash, connect to the WallpaperController interface via mojo.
     service_manager::Connector* connector =
         content::ServiceManagerConnection::GetForProcess()->GetConnector();
     if (!connector)
       return;
 
     ash::mojom::WallpaperControllerPtr wallpaper_controller;
     connector->BindInterface(ash::mojom::kServiceName, &wallpaper_controller);
     // TODO(crbug.com/655875): Optimize ash wallpaper transport; avoid sending
@@ skipping 203 matching lines @@
 
 bool WallpaperManager::IsPendingWallpaper(uint32_t image_id) {
   for (size_t i = 0; i < loading_.size(); ++i) {
     if (loading_[i]->GetImageId() == image_id) {
       return true;
     }
   }
   return false;
 }
 
+void WallpaperManager::CalculateProminentColor(const gfx::ImageSkia& image) {
+  // Cancel in-flight color calculations, if any.
+  if (color_calculator_) {
+    color_calculator_->RemoveObserver(this);
+    color_calculator_.reset();
+  }
+
+  color_calculator_ = base::MakeUnique<wallpaper::WallpaperColorCalculator>(
+      image, color_utils::LumaRange::DARK, color_utils::SaturationRange::MUTED,

[xdai1, 2017/06/13 23:04:24]

Is the color scheme for the login screen fixed? Can we use the same color scheme
as in the shelf? If so, maybe they can share codes?

[Wenzhao (Colin) Zang, 2017/06/14 00:44:50]

The color scheme for the shelf is derived from the command line, as in 
(please open in a new tab)

https://cs.chromium.org/chromium/src/ash/wallpaper/wallpaper_controller.cc?dr...

However the login screen always has a fixed color scheme, so they are not the
same.

[xdai1, 2017/06/14 18:23:40]

The code logic of WallpaperColorCalculator here is almost the same as in
WallpaperController, except the color scheme (even for the color scheme, the
command switch in the shelf might be only used for developing/testing purpose. I
don't think we set different shelf color scheme for different device board). And
the color seems calculated twice in the same function SetWallpaper()
 (WallpaperController::CalculateWallpaperColors() is called in the sub-function
of SetWallpaper()), which seems redundant?

So instead of making SigninScreenHandler an observer of WallpaperManagerBase, it
might be better to make it an observer of WallpaperController?

[xiyuan, 2017/06/14 18:28:26]

WallpaperController is part of ash. If we do that, we need to do it via mojo to
be ready for mash.

[Wenzhao (Colin) Zang, 2017/06/15 05:02:08]

I understand the concerns. Before writing this CL I already realized it's better
to make it an observer of WallpaperController. So please advise on the following
options:

1) We may not need to fix crbug.com/733391 for now, because this CL, including
most other codes related to login screen will be discarded very soon, since the
login screen will be completely re-implemented. So this CL and some other CLs
I'm working on are temporary codes in order to meet the hard deadline - M61.
This is the last major chunk of codes before completing the MD login screen
re-design, and the UI review team already complains about the lack of color
extraction. So are these codes acceptable for just two months?

2) If the codes are unacceptable, and we want to start working on
crbug.com/733391 now (but the codes are likely to be discarded in two months
too), I really need an alternative way to extract colors which can be used
before the mojo calls are ready. Are there any suggestions? Because the
background color is an integral part of the login screen, the earlier the
UI-review team can see the color extraction results the more time I'll have to
fix other potential issues before M61.  

Thanks.

+      task_runner_);
+  color_calculator_->AddObserver(this);
+  if (!color_calculator_->StartCalculation()) {

[xdai1, 2017/06/13 23:04:24]

If the calculation fails to be initiated, why do we need to inform the observer
the complete event?

[Wenzhao (Colin) Zang, 2017/06/14 00:44:50]

Because the front end needs to be notified of the failure, and it will check
whether the optional value exists to determine the status. The function name may
wrongly imply that the calculation always completes, so the name is changed.

+    prominent_color_.reset();
+    for (auto& observer : observers_)
+      observer.OnColorCalculationComplete();
+  }
+}
+
 WallpaperManager::WallpaperResolution
 WallpaperManager::GetAppropriateResolution() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   gfx::Size size = ash::WallpaperController::GetMaxDisplaySizeInNative();
   return (size.width() > wallpaper::kSmallWallpaperMaxWidth ||
           size.height() > wallpaper::kSmallWallpaperMaxHeight)
              ? WALLPAPER_RESOLUTION_LARGE
              : WALLPAPER_RESOLUTION_SMALL;
 }
 
@@ skipping 464 matching lines @@
     window_observer_.Add(gained_active);
   }
 }
 
 void WallpaperManager::OnWindowDestroying(aura::Window* window) {
   window_observer_.Remove(window);
   chromeos::WallpaperWindowStateManager::RestoreWindows(
       user_manager::UserManager::Get()->GetActiveUser()->username_hash());
 }
 
+void WallpaperManager::OnColorCalculationComplete() {
+  if (color_calculator_->prominent_color() == prominent_color_)
+    return;

[xiyuan, 2017/06/13 23:23:48]

|color_calculator_|.reset() is skipped when this happens.

[Wenzhao (Colin) Zang, 2017/06/14 00:44:50]

Done. Thanks for pointing it out.

+  prominent_color_ = color_calculator_->prominent_color();
+  color_calculator_.reset();
+  for (auto& observer : observers_)
+    observer.OnColorCalculationComplete();
+}
+
 // WallpaperManager, private: --------------------------------------------------
 
 WallpaperManager::WallpaperManager()
     : binding_(this),
       pending_inactive_(nullptr),
       activation_client_observer_(this),
       window_observer_(this),
       weak_factory_(this) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   wallpaper::WallpaperManagerBase::SetPathIds(
@@ skipping 521 matching lines @@
 
   UMA_HISTOGRAM_ENUMERATION(
       "Ash.Wallpaper.Apps",
       wallpaper_manager_util::ShouldUseAndroidWallpapersApp(profile)
           ? WALLPAPERS_APP_ANDROID
           : WALLPAPERS_PICKER_APP_CHROMEOS,
       WALLPAPERS_APPS_NUM);
 }
 
 }  // namespace chromeos