Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2931033005: Small fixes for Servicified SW code path (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/service_worker/service_worker_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 67ae44acdd11aee6bfad43f2c7fc953dcc39548b..c595af5eaa1ce9775cc1bcd2c25e9b0be49b5cea 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -67,6 +67,7 @@
#include "content/common/page_messages.h"
#include "content/common/savable_subframe.h"
#include "content/common/service_worker/service_worker_types.h"
+#include "content/common/service_worker/service_worker_utils.h"
#include "content/common/site_isolation_policy.h"
#include "content/common/swapped_out_messages.h"
#include "content/common/view_messages.h"
@@ -2918,6 +2919,8 @@ RenderFrameImpl::CreateWorkerFetchContext() {
ServiceWorkerNetworkProvider* provider =
ServiceWorkerNetworkProvider::FromWebServiceWorkerNetworkProvider(
web_provider);
+ if (!provider)
+ return nullptr;
worker_fetch_context->set_service_worker_provider_id(
provider->provider_id());
worker_fetch_context->set_is_controlled_by_service_worker(
@@ -2969,6 +2972,10 @@ RenderFrameImpl::CreateServiceWorkerProvider() {
ServiceWorkerNetworkProvider* provider =
ServiceWorkerNetworkProvider::FromWebServiceWorkerNetworkProvider(
frame_->DataSource()->GetServiceWorkerNetworkProvider());
+ if (!provider) {
+ DCHECK(ServiceWorkerUtils::IsServicificationEnabled());
+ return nullptr;
+ }
if (!provider->context()) {
// The context can be null when the frame is sandboxed.
return nullptr;
@@ -3426,6 +3433,12 @@ void RenderFrameImpl::DidCreateDataSource(blink::WebLocalFrame* frame,
if (datasource->GetServiceWorkerNetworkProvider())
return;
+ if (ServiceWorkerUtils::IsServicificationEnabled()) {
+ // Disable interception via ServiceWorkerNetworkProvider if
+ // servicification is enabled.
+ return;
+ }
+
datasource->SetServiceWorkerNetworkProvider(
ServiceWorkerNetworkProvider::CreateForNavigation(
routing_id_, navigation_state->request_params(), frame,
« no previous file with comments | « content/common/service_worker/service_worker_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698