Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1895)

Unified Diff: chrome/browser/resource_coordinator/tab_manager_web_contents_data.h

Issue 2931023002: [TooManyTabs] Add TabNavigationThrottle (Closed)
Patch Set: review fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resource_coordinator/tab_manager_web_contents_data.h
diff --git a/chrome/browser/resource_coordinator/tab_manager_web_contents_data.h b/chrome/browser/resource_coordinator/tab_manager_web_contents_data.h
index 26749d436abd6e3d17c5804a889b850af9a9e03c..6b765c1919eb238066de56a383ee6ffd677ae102 100644
--- a/chrome/browser/resource_coordinator/tab_manager_web_contents_data.h
+++ b/chrome/browser/resource_coordinator/tab_manager_web_contents_data.h
@@ -32,6 +32,9 @@ class TabManager::WebContentsData
// WebContentsObserver implementation:
void DidStartLoading() override;
+ void DidStopLoading() override;
+ void DidStartNavigation(
+ content::NavigationHandle* navigation_handle) override;
void WebContentsDestroyed() override;
// Returns true if the tab has been discarded to save memory.
@@ -112,6 +115,8 @@ class TabManager::WebContentsData
int discard_count;
// Is the tab playing audio?
bool is_recently_audible;
+ // Has the tab finished loading?
+ bool has_finished_loading;
chrisha 2017/06/15 21:02:24 Another CL is adding a loading state... can this w
Zhen Wang 2017/06/19 23:00:12 I agree. I intended to use the other CL's loading
// Last time the tab started or stopped playing audio (we record the
// transition time).
base::TimeTicks last_audio_change_time;

Powered by Google App Engine
This is Rietveld 408576698