content/public/browser/web_contents.h - Issue 2931023002: [TooManyTabs] Add TabNavigationThrottle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents.h

Issue 2931023002: [TooManyTabs] Add TabNavigationThrottle (Closed)

Patch Set: add more tests Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/web_contents.h

diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h

index 5881c954de4880deed9f61998c4c730e457b0199..c02c2e840f0074fb850892c17856995a6da86795 100644

--- a/content/public/browser/web_contents.h

+++ b/content/public/browser/web_contents.h

@@ -442,6 +442,9 @@ class WebContents : public PageNavigator,

virtual void WasShown() = 0;

virtual void WasHidden() = 0;

+ // Whether the WebContents is visible.

+ virtual bool IsVisible() const = 0;

Charlie Reis 2017/07/06 23:50:31 I still find this confusing vs RWHV::IsShowing(),

Zhen Wang 2017/07/07 18:06:39 Added comments now. Ken, can you double check if t

// Returns true if the before unload and unload listeners need to be

// fired. The value of this changes over time. For example, if true and the

// before unload listener is executed and allows the user to exit, then this