Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2580)

Unified Diff: chrome/browser/resource_coordinator/tab_manager_web_contents_data.cc

Issue 2931023002: [TooManyTabs] Add TabNavigationThrottle (Closed)
Patch Set: add more tests Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resource_coordinator/tab_manager_web_contents_data.cc
diff --git a/chrome/browser/resource_coordinator/tab_manager_web_contents_data.cc b/chrome/browser/resource_coordinator/tab_manager_web_contents_data.cc
index 715d09cbb41afcc2c0000afe29ac0473aef45f6e..42c1345d4f75480c5ca6292db50cbde09e7f55f3 100644
--- a/chrome/browser/resource_coordinator/tab_manager_web_contents_data.cc
+++ b/chrome/browser/resource_coordinator/tab_manager_web_contents_data.cc
@@ -9,7 +9,9 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/engagement/site_engagement_service.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/resource_coordinator/tab_manager.h"
#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/navigation_handle.h"
#include "content/public/browser/web_contents.h"
using base::TimeTicks;
@@ -42,6 +44,7 @@ void TabManager::WebContentsData::DidStopLoading() {
// when available.
if (tab_data_.tab_loading_state != TAB_IS_LOADED) {
SetTabLoadingState(TAB_IS_LOADED);
+ g_browser_process->GetTabManager()->OnLoadingDone(web_contents());
Charlie Reis 2017/07/06 23:50:30 Can we stick with the existing names (i.e., OnDidS
Zhen Wang 2017/07/07 18:06:39 Done.
}
}
@@ -58,6 +61,11 @@ void TabManager::WebContentsData::DidStartNavigation(
SetTabLoadingState(TAB_IS_LOADING);
}
+void TabManager::WebContentsData::DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) {
+ g_browser_process->GetTabManager()->OnNavigationDone(navigation_handle);
+}
+
void TabManager::WebContentsData::WebContentsDestroyed() {
// If Chrome is shutting down, ignore this event.
if (g_browser_process->IsShuttingDown())
@@ -73,6 +81,9 @@ void TabManager::WebContentsData::WebContentsDestroyed() {
base::TimeDelta::FromSeconds(1),
base::TimeDelta::FromDays(1), 100);
}
+
+ SetTabLoadingState(TAB_IS_NOT_LOADING);
+ g_browser_process->GetTabManager()->OnWebContentsDestroyed(web_contents());
}
bool TabManager::WebContentsData::IsDiscarded() {

Powered by Google App Engine
This is Rietveld 408576698