Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: chrome/browser/resource_coordinator/tab_navigation_throttle.h

Issue 2931023002: [TooManyTabs] Add TabNavigationThrottle (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_RESOURCE_COORDINATOR_TAB_NAVIGATION_THROTTLE_H_
6 #define CHROME_BROWSER_RESOURCE_COORDINATOR_TAB_NAVIGATION_THROTTLE_H_
7
8 #include <memory>
9
10 #include "base/macros.h"
11 #include "content/public/browser/navigation_throttle.h"
12
13 namespace resource_coordinator {
14
15 // TabNavigationThrottle plumbs navigation information to TabManager and enables
16 // TabManager to control navigation for background tabs.
Charlie Reis 2017/06/10 00:53:36 Can you elaborate on this a bit more? "Controllin
Zhen Wang 2017/06/13 23:33:21 I replaced "control" with "delay". We indeed just
17 class TabNavigationThrottle : public content::NavigationThrottle {
Charlie Reis 2017/06/10 00:53:36 This name seems too broad, since most navigation t
Zhen Wang 2017/06/13 23:33:21 SG. Renamed.
18 public:
19 static std::unique_ptr<TabNavigationThrottle> MaybeCreateThrottleFor(
20 content::NavigationHandle* navigation_handle);
21
22 explicit TabNavigationThrottle(content::NavigationHandle* navigation_handle);
23 ~TabNavigationThrottle() override;
24
25 // content::NavigationThrottle implementation
26 const char* GetNameForLogging() override;
27 content::NavigationThrottle::ThrottleCheckResult WillStartRequest() override;
28
29 private:
30 DISALLOW_COPY_AND_ASSIGN(TabNavigationThrottle);
31 };
32
33 } // namespace resource_coordinator
34
35 #endif // CHROME_BROWSER_RESOURCE_COORDINATOR_TAB_NAVIGATION_THROTTLE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698