linux: use some more GDK_ cursor constants for panning cursors

linux: use some more GDK_ cursor constants for panning cursors

These aren't the greatest, but I don't think there are better options.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52386

[Evan Martin, 2010-07-12 22:51:57]

http://www.corp.google.com/~evanm/data/cursors.ogv

[Elliot Glaysher, 2010-07-12 22:57:20]

LGTM. I had no idea that icon was called a "Fleur". Also, GDK_TREK.

-- Elliot

On Mon, Jul 12, 2010 at 3:51 PM,  <evan@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Message:
> http://www.corp.google.com/~evanm/data/cursors.ogv
>
> Description:
> linux: use some more GDK_ cursor constants for panning cursors
>
> These aren't the greatest, but I don't think there are better options.
>
> Please review this at http://codereview.chromium.org/2931011/show
>
> Affected files:
>  M webkit/glue/webcursor_gtk.cc
>
>
> Index: webkit/glue/webcursor_gtk.cc
> diff --git a/webkit/glue/webcursor_gtk.cc b/webkit/glue/webcursor_gtk.cc
> index
>
011005fb590a4468deee5885cf7e9d0c42cc801e..a184e6962e2ea4947cc645115e1cc92a61176eb4
> 100644
> --- a/webkit/glue/webcursor_gtk.cc
> +++ b/webkit/glue/webcursor_gtk.cc
> @@ -1,6 +1,6 @@
> -// Copyright (c) 2008 The Chromium Authors. All rights reserved.  Use of
> this
> -// source code is governed by a BSD-style license that can be found in the
> -// LICENSE file.
> +// Copyright (c) 2010 The Chromium Authors. All rights reserved.
> +// Use of this source code is governed by a BSD-style license that can be
> +// found in the LICENSE file.
>
>  #include "webkit/glue/webcursor.h"
>
> @@ -86,23 +86,23 @@ int WebCursor::GetCursorType() const {
>     case WebCursorInfo::TypeRowResize:
>       return GDK_SB_V_DOUBLE_ARROW;  // TODO(evanm): is this correct?
>     case WebCursorInfo::TypeMiddlePanning:
> -      NOTIMPLEMENTED(); return GDK_LAST_CURSOR;
> +      return GDK_FLEUR;
>     case WebCursorInfo::TypeEastPanning:
> -      NOTIMPLEMENTED(); return GDK_LAST_CURSOR;
> +      return GDK_SB_RIGHT_ARROW;
>     case WebCursorInfo::TypeNorthPanning:
> -      NOTIMPLEMENTED(); return GDK_LAST_CURSOR;
> +      return GDK_SB_UP_ARROW;
>     case WebCursorInfo::TypeNorthEastPanning:
> -      NOTIMPLEMENTED(); return GDK_LAST_CURSOR;
> +      return GDK_TOP_RIGHT_CORNER;
>     case WebCursorInfo::TypeNorthWestPanning:
> -      NOTIMPLEMENTED(); return GDK_LAST_CURSOR;
> +      return GDK_TOP_LEFT_CORNER;
>     case WebCursorInfo::TypeSouthPanning:
> -      NOTIMPLEMENTED(); return GDK_LAST_CURSOR;
> +      return GDK_SB_DOWN_ARROW;
>     case WebCursorInfo::TypeSouthEastPanning:
> -      NOTIMPLEMENTED(); return GDK_LAST_CURSOR;
> +      return GDK_BOTTOM_RIGHT_CORNER;
>     case WebCursorInfo::TypeSouthWestPanning:
> -      NOTIMPLEMENTED(); return GDK_LAST_CURSOR;
> +      return GDK_BOTTOM_LEFT_CORNER;
>     case WebCursorInfo::TypeWestPanning:
> -      NOTIMPLEMENTED(); return GDK_LAST_CURSOR;
> +      return GDK_SB_LEFT_ARROW;
>     case WebCursorInfo::TypeMove:
>       return GDK_FLEUR;
>     case WebCursorInfo::TypeVerticalText:
>
>
>