Address additional analysis issues in the observatory codebase.

runtime/observatory/tests/service/async_step_out_test.dart

Index: runtime/observatory/tests/service/async_step_out_test.dart
diff --git a/runtime/observatory/tests/service/async_step_out_test.dart b/runtime/observatory/tests/service/async_step_out_test.dart
index 8c6718c991feb29c9844b61c0c93294558188bec..5c432c96e911bef6b0203b178960387c6b7ac5ac 100644
--- a/runtime/observatory/tests/service/async_step_out_test.dart
+++ b/runtime/observatory/tests/service/async_step_out_test.dart
@@ -4,18 +4,11 @@
 // VMOptions=--error_on_bad_type --error_on_bad_override  --verbose_debug --async_debugger
 
 import 'dart:developer';
-import 'package:observatory/models.dart' as M;
-import 'package:observatory/service_io.dart';
-import 'package:unittest/unittest.dart';
+import 'dart:io';
+
 import 'service_test_common.dart';
 import 'test_helper.dart';
 
-const LINE_A = 20;
-const LINE_B = 21;
-const LINE_C = 26;
-const LINE_D = 27;
-const LINE_E = 28;
-
 helper() async {
   print('helper'); // LINE_A.
   print('foobar'); // LINE_B.
@@ -28,21 +21,23 @@ testMain() async {
   print('z'); // LINE_E.
 }
 
+final ScriptLineParser lineParser = new ScriptLineParser(Platform.script);
+
 var tests = [
   hasStoppedAtBreakpoint,
-  stoppedAtLine(LINE_C),
+  stoppedAtLine(lineParser.lineFor('LINE_C')),
   stepOver, // print.
   hasStoppedAtBreakpoint,
-  stoppedAtLine(LINE_D),
+  stoppedAtLine(lineParser.lineFor('LINE_D')),
   stepInto,
   hasStoppedAtBreakpoint,
-  stoppedAtLine(LINE_A),
+  stoppedAtLine(lineParser.lineFor('LINE_A')),
   stepOver, // print.
   hasStoppedAtBreakpoint,
-  stoppedAtLine(LINE_B),
+  stoppedAtLine(lineParser.lineFor('LINE_B')),
   stepOut, // out of helper to awaiter testMain.
   hasStoppedAtBreakpoint,
-  stoppedAtLine(LINE_E),
+  stoppedAtLine(lineParser.lineFor('LINE_E')),
 ];
 
 main(args) => runIsolateTests(args, tests, testeeConcurrent: testMain);