Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: runtime/observatory/tests/service/async_single_step_out_test.dart

Issue 2930993004: Address additional analysis issues in the observatory codebase. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/async_single_step_out_test.dart
diff --git a/runtime/observatory/tests/service/async_single_step_out_test.dart b/runtime/observatory/tests/service/async_single_step_out_test.dart
index f66360f1507e727c90e76cf575a2fd063026eccd..4262f6c213d2e9faec01f8c6495f800366acb8f7 100644
--- a/runtime/observatory/tests/service/async_single_step_out_test.dart
+++ b/runtime/observatory/tests/service/async_single_step_out_test.dart
@@ -4,18 +4,11 @@
// VMOptions=--error_on_bad_type --error_on_bad_override --verbose_debug --async_debugger
import 'dart:developer';
-import 'package:observatory/models.dart' as M;
-import 'package:observatory/service_io.dart';
-import 'package:unittest/unittest.dart';
+import 'dart:io';
+
import 'service_test_common.dart';
import 'test_helper.dart';
-const LINE_A = 20;
-const LINE_B = 21;
-const LINE_C = 26;
-const LINE_D = 27;
-const LINE_E = 28;
-
helper() async {
print('helper'); // LINE_A.
return null; // LINE_B.
@@ -28,21 +21,23 @@ testMain() async {
print('z'); // LINE_E.
}
+final ScriptLineParser lineParser = new ScriptLineParser(Platform.script);
+
var tests = [
hasStoppedAtBreakpoint,
- stoppedAtLine(LINE_C),
+ stoppedAtLine(lineParser.lineFor('LINE_C')),
stepOver, // print.
hasStoppedAtBreakpoint,
- stoppedAtLine(LINE_D),
+ stoppedAtLine(lineParser.lineFor('LINE_D')),
stepInto,
hasStoppedAtBreakpoint,
- stoppedAtLine(LINE_A),
+ stoppedAtLine(lineParser.lineFor('LINE_A')),
stepOver, // print.
hasStoppedAtBreakpoint,
- stoppedAtLine(LINE_B), // return null.
+ stoppedAtLine(lineParser.lineFor('LINE_B')), // return null.
stepInto, // exit helper via a single step.
hasStoppedAtBreakpoint,
- stoppedAtLine(LINE_E), // arrive after the await.
+ stoppedAtLine(lineParser.lineFor('LINE_E')), // arrive after the await.
resumeIsolate
];

Powered by Google App Engine
This is Rietveld 408576698