Issue 2930973002: Remove ClassHierarchy factory constructor.

Issue 2930973002: Remove ClassHierarchy factory constructor. (Closed)

Created:
3 years, 6 months ago by scheglov

Modified:
3 years, 6 months ago

Reviewers:
ahe, Siggi Cherem (dart-lang), Kevin Millikin (Google), Paul Berry

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Remove ClassHierarchy factory constructor. KernelTarget already uses IncrementalClassHierarchy, and other clients either need ClosedWorldClassHierarchy, so should explicitly create it, or don't care, and can be switched to IncrementalClassHierarchy. R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/cf59b1a0f9a485199f431978b9a7d5963a8fa149

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -14 lines)			Patch
M	pkg/front_end/test/fasta/type_inference/type_constraint_gatherer_test.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/front_end/test/fasta/type_inference/type_schema_environment_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/kernel/lib/class_hierarchy.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/kernel/test/class_hierarchy_bench.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/kernel/test/treeshaker_bench.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/kernel/test/treeshaker_membench.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/kernel/test/type_subtype_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/kernel/test/typecheck.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 6 months ago (2017-06-09 01:42:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cf59b1a0f9a485199f431978b9a7d5963a8fa149 (presubmit successful).