Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: runtime/vm/pages.cc

Issue 2930943002: Debug garbage collector does not correctly remove cross-gen garbage (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/pages.cc
diff --git a/runtime/vm/pages.cc b/runtime/vm/pages.cc
index 9c52356321181e21b265ba2db60c021b566e4d9c..6e0300e080f34d546eeced9ff4489c171151e334 100644
--- a/runtime/vm/pages.cc
+++ b/runtime/vm/pages.cc
@@ -959,6 +959,8 @@ void PageSpace::MarkSweep(bool invoke_api_callbacks) {
mid3 = OS::GetCurrentMonotonicMicros();
+ { heap_->new_space()->UnmarkNewSpace(); }
+
if (!FLAG_concurrent_sweep) {
// Sweep all regular sized pages now.
prev_page = NULL;
@@ -975,6 +977,7 @@ void PageSpace::MarkSweep(bool invoke_api_callbacks) {
// Advance to the next page.
page = next_page;
}
+
if (FLAG_verify_after_gc) {
OS::PrintErr("Verifying after sweeping...");
heap_->VerifyGC(kForbidMarked);
« runtime/vm/heap.h ('K') | « runtime/vm/heap_test.cc ('k') | runtime/vm/scavenger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698