Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Side by Side Diff: src/compiler/js-operator.cc

Issue 2930933002: [turbofan] JSCreateClosure doesn't have any JS observable side effects. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-generic-lowering.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/js-operator.h" 5 #include "src/compiler/js-operator.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "src/base/lazy-instance.h" 9 #include "src/base/lazy-instance.h"
10 #include "src/compiler/opcodes.h" 10 #include "src/compiler/opcodes.h"
(...skipping 1046 matching lines...) Expand 10 before | Expand all | Expand 10 after
1057 IrOpcode::kJSCreateArray, Operator::kNoProperties, // opcode 1057 IrOpcode::kJSCreateArray, Operator::kNoProperties, // opcode
1058 "JSCreateArray", // name 1058 "JSCreateArray", // name
1059 value_input_count, 1, 1, 1, 1, 2, // counts 1059 value_input_count, 1, 1, 1, 1, 2, // counts
1060 parameters); // parameter 1060 parameters); // parameter
1061 } 1061 }
1062 1062
1063 const Operator* JSOperatorBuilder::CreateClosure( 1063 const Operator* JSOperatorBuilder::CreateClosure(
1064 Handle<SharedFunctionInfo> shared_info, VectorSlotPair const& feedback, 1064 Handle<SharedFunctionInfo> shared_info, VectorSlotPair const& feedback,
1065 PretenureFlag pretenure) { 1065 PretenureFlag pretenure) {
1066 CreateClosureParameters parameters(shared_info, feedback, pretenure); 1066 CreateClosureParameters parameters(shared_info, feedback, pretenure);
1067 return new (zone()) Operator1<CreateClosureParameters>( // -- 1067 return new (zone()) Operator1<CreateClosureParameters>( // --
1068 IrOpcode::kJSCreateClosure, Operator::kNoThrow, // opcode 1068 IrOpcode::kJSCreateClosure, Operator::kEliminatable, // opcode
1069 "JSCreateClosure", // name 1069 "JSCreateClosure", // name
1070 0, 1, 1, 1, 1, 0, // counts 1070 0, 1, 1, 1, 1, 0, // counts
1071 parameters); // parameter 1071 parameters); // parameter
1072 } 1072 }
1073 1073
1074 const Operator* JSOperatorBuilder::CreateLiteralArray( 1074 const Operator* JSOperatorBuilder::CreateLiteralArray(
1075 Handle<ConstantElementsPair> constant_elements, int literal_flags, 1075 Handle<ConstantElementsPair> constant_elements, int literal_flags,
1076 int literal_index, int number_of_elements) { 1076 int literal_index, int number_of_elements) {
1077 CreateLiteralParameters parameters(constant_elements, number_of_elements, 1077 CreateLiteralParameters parameters(constant_elements, number_of_elements,
1078 literal_flags, literal_index); 1078 literal_flags, literal_index);
1079 return new (zone()) Operator1<CreateLiteralParameters>( // -- 1079 return new (zone()) Operator1<CreateLiteralParameters>( // --
1080 IrOpcode::kJSCreateLiteralArray, Operator::kNoProperties, // opcode 1080 IrOpcode::kJSCreateLiteralArray, Operator::kNoProperties, // opcode
1081 "JSCreateLiteralArray", // name 1081 "JSCreateLiteralArray", // name
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
1150 return new (zone()) Operator1<Handle<ScopeInfo>>( // -- 1150 return new (zone()) Operator1<Handle<ScopeInfo>>( // --
1151 IrOpcode::kJSCreateScriptContext, Operator::kNoProperties, // opcode 1151 IrOpcode::kJSCreateScriptContext, Operator::kNoProperties, // opcode
1152 "JSCreateScriptContext", // name 1152 "JSCreateScriptContext", // name
1153 1, 1, 1, 1, 1, 2, // counts 1153 1, 1, 1, 1, 1, 2, // counts
1154 scope_info); // parameter 1154 scope_info); // parameter
1155 } 1155 }
1156 1156
1157 } // namespace compiler 1157 } // namespace compiler
1158 } // namespace internal 1158 } // namespace internal
1159 } // namespace v8 1159 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/js-generic-lowering.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698