Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 293093010: Rename RenderProcessHost::IsGuest to RenderProcessHost::IsIsolatedGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_isguest_chrome_callsites
Patch Set: Fixed interactive_ui_tests build Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index bfdb976da5e3ca9fe5f05fdc13942a1e7a679e77..74e3c407a8f6377a1055e156e5b22026f9d1bf76 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -391,7 +391,7 @@ void RenderProcessHost::SetMaxRendererProcessCount(size_t count) {
RenderProcessHostImpl::RenderProcessHostImpl(
BrowserContext* browser_context,
StoragePartitionImpl* storage_partition_impl,
- bool is_guest)
+ bool is_isolated_guest)
: fast_shutdown_started_(false),
deleting_soon_(false),
#ifndef NDEBUG
@@ -407,7 +407,7 @@ RenderProcessHostImpl::RenderProcessHostImpl(
storage_partition_impl_(storage_partition_impl),
sudden_termination_allowed_(true),
ignore_input_events_(false),
- is_guest_(is_guest),
+ is_isolated_guest_(is_isolated_guest),
gpu_observer_registered_(false),
delayed_cleanup_needed_(false),
within_process_died_observer_(false),
@@ -941,8 +941,8 @@ int RenderProcessHostImpl::VisibleWidgetCount() const {
return visible_widgets_;
}
-bool RenderProcessHostImpl::IsGuest() const {
- return is_guest_;
+bool RenderProcessHostImpl::IsIsolatedGuest() const {
+ return is_isolated_guest_;
}
StoragePartition* RenderProcessHostImpl::GetStoragePartition() const {
@@ -1583,7 +1583,7 @@ void RenderProcessHostImpl::FilterURL(RenderProcessHost* rph,
// Do not allow browser plugin guests to navigate to non-web URLs, since they
// cannot swap processes or grant bindings.
- bool non_web_url_in_guest = rph->IsGuest() &&
+ bool non_web_url_in_guest = rph->IsIsolatedGuest() &&
!(url->is_valid() && policy->IsWebSafeScheme(url->scheme()));
if (non_web_url_in_guest || !policy->CanRequestURL(rph->GetID(), *url)) {
@@ -1611,7 +1611,7 @@ bool RenderProcessHostImpl::IsSuitableHost(
// and non-guest storage gets mixed. In the future, we might consider enabling
// the sharing of guests, in this case this check should be removed and
// InSameStoragePartition should handle the possible sharing.
- if (host->IsGuest())
+ if (host->IsIsolatedGuest())
return false;
// Check whether the given host and the intended site_url will be using the

Powered by Google App Engine
This is Rietveld 408576698