content/browser/frame_host/navigation_controller_impl.cc - Issue 293093010: Rename RenderProcessHost::IsGuest to RenderProcessHost::IsIsolatedGuest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 293093010: Rename RenderProcessHost::IsGuest to RenderProcessHost::IsIsolatedGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_isguest_chrome_callsites

Patch Set: Fixed interactive_ui_tests build Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_impl.cc

diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc

index d8a4579d72d60c37772420f9d4bb132f08f3302d..54691513c4e6440fbb327cd921af88d3d5f09d5f 100644

--- a/content/browser/frame_host/navigation_controller_impl.cc

+++ b/content/browser/frame_host/navigation_controller_impl.cc

@@ -338,9 +338,9 @@ void NavigationControllerImpl::ReloadInternal(bool check_for_repost,

// instance, and should not be treated as a cross-site reload.

SiteInstanceImpl* site_instance = entry->site_instance();

// Permit reloading guests without further checks.

- bool is_guest = site_instance && site_instance->HasProcess() &&

- site_instance->GetProcess()->IsGuest();

- if (!is_guest && site_instance &&

+ bool is_isolated_guest = site_instance && site_instance->HasProcess() &&

+ site_instance->GetProcess()->IsIsolatedGuest();

+ if (!is_isolated_guest && site_instance &&

site_instance->HasWrongProcessForURL(entry->GetURL())) {

// Create a navigation entry that resembles the current one, but do not

// copy page id, site instance, content state, or timestamp.