Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: chrome/browser/apps/web_view_browsertest.cc

Issue 293093010: Rename RenderProcessHost::IsGuest to RenderProcessHost::IsIsolatedGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_isguest_chrome_callsites
Patch Set: Fixed interactive_ui_tests build Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/apps/web_view_interactive_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/web_view_browsertest.cc
diff --git a/chrome/browser/apps/web_view_browsertest.cc b/chrome/browser/apps/web_view_browsertest.cc
index f4be00b023296157502941e4c91cd13093b0ad0f..db868322d1d0f6718a806c1735725f5e1c20bca8 100644
--- a/chrome/browser/apps/web_view_browsertest.cc
+++ b/chrome/browser/apps/web_view_browsertest.cc
@@ -409,19 +409,26 @@ class WebViewTest : public extensions::PlatformAppBrowserTest {
observer7.Wait();
content::Source<content::NavigationController> source1 = observer1.source();
- EXPECT_TRUE(source1->GetWebContents()->GetRenderProcessHost()->IsGuest());
+ EXPECT_TRUE(source1->GetWebContents()->GetRenderProcessHost()->
+ IsIsolatedGuest());
content::Source<content::NavigationController> source2 = observer2.source();
- EXPECT_TRUE(source2->GetWebContents()->GetRenderProcessHost()->IsGuest());
+ EXPECT_TRUE(source2->GetWebContents()->GetRenderProcessHost()->
+ IsIsolatedGuest());
content::Source<content::NavigationController> source3 = observer3.source();
- EXPECT_TRUE(source3->GetWebContents()->GetRenderProcessHost()->IsGuest());
+ EXPECT_TRUE(source3->GetWebContents()->GetRenderProcessHost()->
+ IsIsolatedGuest());
content::Source<content::NavigationController> source4 = observer4.source();
- EXPECT_TRUE(source4->GetWebContents()->GetRenderProcessHost()->IsGuest());
+ EXPECT_TRUE(source4->GetWebContents()->GetRenderProcessHost()->
+ IsIsolatedGuest());
content::Source<content::NavigationController> source5 = observer5.source();
- EXPECT_TRUE(source5->GetWebContents()->GetRenderProcessHost()->IsGuest());
+ EXPECT_TRUE(source5->GetWebContents()->GetRenderProcessHost()->
+ IsIsolatedGuest());
content::Source<content::NavigationController> source6 = observer6.source();
- EXPECT_TRUE(source6->GetWebContents()->GetRenderProcessHost()->IsGuest());
+ EXPECT_TRUE(source6->GetWebContents()->GetRenderProcessHost()->
+ IsIsolatedGuest());
content::Source<content::NavigationController> source7 = observer7.source();
- EXPECT_TRUE(source7->GetWebContents()->GetRenderProcessHost()->IsGuest());
+ EXPECT_TRUE(source7->GetWebContents()->GetRenderProcessHost()->
+ IsIsolatedGuest());
// Check that the first two tags use the same process and it is different
// than the process used by the other two.
@@ -610,7 +617,8 @@ class WebViewTest : public extensions::PlatformAppBrowserTest {
content::Source<content::NavigationController> source =
guest_observer.source();
- EXPECT_TRUE(source->GetWebContents()->GetRenderProcessHost()->IsGuest());
+ EXPECT_TRUE(source->GetWebContents()->GetRenderProcessHost()->
+ IsIsolatedGuest());
bool satisfied = guest_loaded_listener.WaitUntilSatisfied();
if (!satisfied)
@@ -1119,7 +1127,8 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestRemoveWebviewOnExit) {
content::Source<content::NavigationController> source =
guest_observer.source();
- EXPECT_TRUE(source->GetWebContents()->GetRenderProcessHost()->IsGuest());
+ EXPECT_TRUE(source->GetWebContents()->GetRenderProcessHost()->
+ IsIsolatedGuest());
ASSERT_TRUE(guest_loaded_listener.WaitUntilSatisfied());
@@ -1201,7 +1210,7 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, MAYBE_InterstitialTeardown) {
// Wait for interstitial page to be shown in guest.
content::WebContents* guest_web_contents = new_client.WaitForGuestCreated();
SetBrowserClientForTesting(old_client);
- ASSERT_TRUE(guest_web_contents->GetRenderProcessHost()->IsGuest());
+ ASSERT_TRUE(guest_web_contents->GetRenderProcessHost()->IsIsolatedGuest());
WaitForInterstitial(guest_web_contents);
// Now close the app while interstitial page being shown in guest.
« no previous file with comments | « no previous file | chrome/browser/apps/web_view_interactive_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698