content/browser/browser_plugin/browser_plugin_guest.cc - Issue 293093010: Rename RenderProcessHost::IsGuest to RenderProcessHost::IsIsolatedGuest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 293093010: Rename RenderProcessHost::IsGuest to RenderProcessHost::IsIsolatedGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_isguest_chrome_callsites

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/guest_view_manager.cc ('k') | content/browser/frame_host/navigation_controller_impl.cc » ('j') | content/browser/renderer_host/render_process_host_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.cc

diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc

index 3842a85744a04ccbd6285abd903399d9b67064ab..bdf7da5b6f3639b37db27a326b6824446f4efde9 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.cc

+++ b/content/browser/browser_plugin/browser_plugin_guest.cc

@@ -615,8 +615,6 @@ void BrowserPluginGuest::DidStopLoading(RenderViewHost* render_view_host) {

void BrowserPluginGuest::RenderViewReady() {

RenderViewHost* rvh = GetWebContents()->GetRenderViewHost();

- // The guest RenderView should always live in a guest process.

lazyboy 2014/05/27 19:22:22 I'd keep this until we start upstreaming appview c

Fady Samuel 2014/05/27 21:56:34 This seems more appropriately in WebViewGuest. I'v

- CHECK(rvh->GetProcess()->IsGuest());

// TODO(fsamuel): Investigate whether it's possible to update state earlier

// here (see http://crbug.com/158151).

Send(new InputMsg_SetFocus(routing_id(), focused_));