content/public/test/mock_render_process_host.h - Issue 293093010: Rename RenderProcessHost::IsGuest to RenderProcessHost::IsIsolatedGuest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/mock_render_process_host.h

Issue 293093010: Rename RenderProcessHost::IsGuest to RenderProcessHost::IsIsolatedGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_isguest_chrome_callsites

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/render_process_host.h ('K') | « content/public/browser/render_process_host.h ('k') | content/public/test/mock_render_process_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/mock_render_process_host.h

diff --git a/content/public/test/mock_render_process_host.h b/content/public/test/mock_render_process_host.h

index 4b99782bd5d5bc4ec3f101b00f2b269afe9b76a1..4beac44da95b40f5808bb512650c111f079cd3b5 100644

--- a/content/public/test/mock_render_process_host.h

+++ b/content/public/test/mock_render_process_host.h

@@ -47,7 +47,7 @@ class MockRenderProcessHost : public RenderProcessHost {

virtual void WidgetRestored() OVERRIDE;

virtual void WidgetHidden() OVERRIDE;

virtual int VisibleWidgetCount() const OVERRIDE;

- virtual bool IsGuest() const OVERRIDE;

+ virtual bool IsIsolatedGuest() const OVERRIDE;

virtual StoragePartition* GetStoragePartition() const OVERRIDE;

virtual void AddWord(const base::string16& word);

virtual bool FastShutdownIfPossible() OVERRIDE;

@@ -97,8 +97,8 @@ class MockRenderProcessHost : public RenderProcessHost {

int GetActiveViewCount();

- void SetIsGuest(bool is_guest) {

- is_guest_ = is_guest;

+ void SetIsIsolatedGuest(bool is_guest) {

lazyboy 2014/05/27 19:22:22 Since this is direct setter, should be set_is_isol

Fady Samuel 2014/05/27 21:56:34 It looks like this isn't even used. I've removed i

+ is_isolated_guest_ = is_guest;

}

private:

@@ -115,7 +115,7 @@ class MockRenderProcessHost : public RenderProcessHost {

IDMap<IPC::Listener> listeners_;

bool fast_shutdown_started_;

bool deletion_callback_called_;

- bool is_guest_;

+ bool is_isolated_guest_;

DISALLOW_COPY_AND_ASSIGN(MockRenderProcessHost);

};