Rename RenderProcessHost::IsGuest to RenderProcessHost::IsIsolatedGuest

content/public/test/mock_render_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/test/mock_render_process_host.h"
 
 #include "base/lazy_instance.h"
 #include "base/message_loop/message_loop.h"
 #include "base/time/time.h"
 #include "content/browser/child_process_security_policy_impl.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/common/child_process_host_impl.h"
 #include "content/public/browser/global_request_id.h"
 #include "content/public/browser/render_widget_host_iterator.h"
 #include "content/public/browser/storage_partition.h"
 
 namespace content {
 
 MockRenderProcessHost::MockRenderProcessHost(BrowserContext* browser_context)
     : bad_msg_count_(0),
       factory_(NULL),
       id_(ChildProcessHostImpl::GenerateChildProcessUniqueId()),
       browser_context_(browser_context),
       prev_routing_id_(0),
       fast_shutdown_started_(false),
-      deletion_callback_called_(false),
-      is_guest_(false) {
+      deletion_callback_called_(false) {
   // Child process security operations can't be unit tested unless we add
   // ourselves as an existing child process.
   ChildProcessSecurityPolicyImpl::GetInstance()->Add(GetID());
 
   RenderProcessHostImpl::RegisterHost(GetID(), this);
 }
 
 MockRenderProcessHost::~MockRenderProcessHost() {
   ChildProcessSecurityPolicyImpl::GetInstance()->Remove(GetID());
   if (factory_)
@@ skipping 54 matching lines @@
 void MockRenderProcessHost::WidgetRestored() {
 }
 
 void MockRenderProcessHost::WidgetHidden() {
 }
 
 int MockRenderProcessHost::VisibleWidgetCount() const {
   return 1;
 }
 
-bool MockRenderProcessHost::IsGuest() const {
-  return is_guest_;
+bool MockRenderProcessHost::IsIsolatedGuest() const {
+  return false;

[nasko, 2014/05/28 16:29:13]

Is it no longer true that content/ on its own can have isolated guests? It seems
to me that we need a test case inside content/ that ensures the isolation is
working without depending on chrome/ for it.

[fsamuel, 2014/05/28 16:37:01]

Yes, it is true. BrowserPlugin is now inert without chrome.

 }
 
 StoragePartition* MockRenderProcessHost::GetStoragePartition() const {
   return NULL;
 }
 
 void MockRenderProcessHost::AddWord(const base::string16& word) {
 }
 
 bool MockRenderProcessHost::FastShutdownIfPossible() {
@@ skipping 162 matching lines @@
   for (ScopedVector<MockRenderProcessHost>::iterator it = processes_.begin();
        it != processes_.end(); ++it) {
     if (*it == host) {
       processes_.weak_erase(it);
       break;
     }
   }
 }
 
 }  // content