components/autofill/content/common/autofill_messages.h - Issue 293093002: Don't show "Save password" prompt for a failed login

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 293093002: Don't show "Save password" prompt for a failed login (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use exising done.html file for the test case that a iframe doesn't contain any form. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index f9a99fe670dea7fccaf93328f7517227906990e1..f35b44ecfc9eace9473624de4a635c8a8a53050d 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -195,9 +195,11 @@ IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormsParsed,

std::vector<autofill::PasswordForm> /* forms */)

// Notification that initial layout has occurred and the following password

-// forms are visible on the page (e.g. not set to display:none.)

-IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormsRendered,

- std::vector<autofill::PasswordForm> /* forms */)

+// forms are visible on the page (e.g. not set to display:none.), and whether

+// all frames in the page have been rendered.

+IPC_MESSAGE_ROUTED2(AutofillHostMsg_PasswordFormsRendered,

+ std::vector<autofill::PasswordForm> /* forms */,

+ bool /* true if all frames have been rendered */)

Ilya Sherman 2014/06/20 20:31:45 nit: The comment should be a variable name, rather

// Notification that this password form was submitted by the user.

IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormSubmitted,

« no previous file with comments | « chrome/test/data/password/multi_frames.html ('k') | components/autofill/content/renderer/password_autofill_agent.h » ('j') | no next file with comments »