Don't show "Save password" prompt for a failed login

chrome/browser/password_manager/password_manager_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram_samples.h"
 #include "base/metrics/statistics_recorder.h"
 #include "chrome/browser/chrome_notification_types.h"
@@ skipping 359 matching lines @@
       "frame_doc.getElementById('password_field').value = 'random';"
       "frame_doc.getElementById('input_submit_button').click();";
 
   ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), navigate_frame));
   ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_submit));
   observer.Wait();
   EXPECT_TRUE(observer.infobar_shown());
 }
 
 IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
+                       NoPromptForFailedLoginWithSubFrameNavigation) {
+  NavigateToFile("/password/multi_frames.html");
+
+  // Make sure that we don't prompt to save the password for a failed login
+  // with a sub-frame navigation happens first.

[vabr (Chromium), 2014/06/11 08:22:12]

nit: with -> when

+  NavigationObserver observer(WebContents());
+  observer.SetPathToWaitFor("/password/failed.html");
+  std::string navigate_frame =
+      "var second_iframe = document.getElementById('second_frame');"
+      "second_iframe.contentWindow.location.href = 'other.html';";
+  std::string fill_and_submit =
+      "var first_frame = document.getElementById('first_frame');"
+      "var frame_doc = first_frame.contentDocument;"
+      "frame_doc.getElementById('username_failed').value = 'temp';"
+      "frame_doc.getElementById('password_failed').value = 'random';"
+      "frame_doc.getElementById('submit_failed').click()";
+
+  ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), navigate_frame));
+  ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_submit));

[vabr (Chromium), 2014/06/11 08:22:12]

Sorry, but I still don't see how this test relates to the original problem. Why
does there need to be the navigation to the second frame before the form is even
submitted?

Should not the test be something like:
1. Submit a form in a sub-frame.
2. Navigate the main frame to multi_frames.html again.

Then it would test that it only takes one sub-frame to contain the login form
again, to stop the infobar from showing.

+  observer.Wait();
+  EXPECT_FALSE(observer.infobar_shown());
+}
+
+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
                        PromptForXHRSubmit) {
 #if defined(OS_WIN) && defined(USE_ASH)
   // Disable this test in Metro+Ash for now (http://crbug.com/262796).
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
     return;
 #endif
   NavigateToFile("/password/password_xhr_submit.html");
 
   // Verify that we show the save password prompt if a form returns false
   // in its onsubmit handler but instead logs in/navigates via XHR.
@@ skipping 357 matching lines @@
   ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill));
 
   NavigationObserver observer(WebContents());
   GURL url = embedded_test_server()->GetURL("/password/password_form.html");
   chrome::NavigateParams params(browser(), url,
                                 content::PAGE_TRANSITION_RELOAD);
   ui_test_utils::NavigateToURL(&params);
   observer.Wait();
   EXPECT_FALSE(observer.infobar_shown());
 }