chrome/test/data/password/multi_frames.html - Issue 293093002: Don't show "Save password" prompt for a failed login

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/password/multi_frames.html

Issue 293093002: Don't show "Save password" prompt for a failed login (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missed filed from last upload. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <html>	1 <html>

2 <body>	2 <body>

3	3

	4 <iframe src="no_form.html" id="no_form_frame" name="no_form_frame">
	vabr (Chromium) 2014/06/13 08:12:44 optional nit: You could also re-use 'done.html' an optional nit: You could also re-use 'done.html' and add a sentence in the body of done.html saying something like: "This file should not contain any forms." But if you prefer a separate no_form.html, that's fine with me. ziran.sun 2014/06/13 10:58:26 Done. Show quoted text On 2014/06/13 08:12:44, vabr (Chromium) wrote: > optional nit: You could also re-use 'done.html' and add a sentence in the body > of done.html saying something like: "This file should not contain any forms." > But if you prefer a separate no_form.html, that's fine with me. Done.
	5 </iframe>

4 <iframe src="password_form.html" id="first_frame" name="first_frame">	6 <iframe src="password_form.html" id="first_frame" name="first_frame">

5 </iframe>	7 </iframe>

6 <iframe src="password_form.html" id="second_frame" name="second_frame">	8 <iframe src="password_form.html" id="second_frame" name="second_frame">

7 </iframe>	9 </iframe>

8	10

9 <form method="POST" action="done.html" onsubmit="return false;" id="testform">	11 <form method="POST" action="done.html" onsubmit="return false;" id="testform">

10 <input type="text" id="username_field" name="username_field">	12 <input type="text" id="username_field" name="username_field">

11 <input type="password" id="password_field" name="password_field">	13 <input type="password" id="password_field" name="password_field">

12 <input type="submit" id="input_submit_button" name="input_submit_button">	14 <input type="submit" id="input_submit_button" name="input_submit_button">

13 </form>	15 </form>

14	16

	17 <form method="POST" action="multi_frames.html" id="to_multi_frames">

	18 <input type="text" id="username_failed" name="username_failed">

	19 <input type="password" id="password_failed" name="password_failed">

	20 <input type="submit" id="submit_failed" name="submit_failed">

	21 </form>

	22

15 </body>	23 </body>

16 </html>	24 </html>

OLD	NEW

« no previous file with comments | « chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('k') | chrome/test/data/password/no_form.html » ('j') | no next file with comments »