Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: src/assembler.h

Issue 2930833002: [wasm] Wasm Memory/Table relocations should not be GC'ed enums (Closed)
Patch Set: Mircea's review Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/assembler.h
diff --git a/src/assembler.h b/src/assembler.h
index 6e845bdf413fad8c5b04c9245c7c01a96874185d..4688688cebc8ca45dd64189d44af7c6052211de1 100644
--- a/src/assembler.h
+++ b/src/assembler.h
@@ -348,7 +348,9 @@ class RelocInfo {
CODE_TARGET,
CODE_TARGET_WITH_ID,
EMBEDDED_OBJECT,
- // To relocate pointers into the wasm memory embedded in wasm code
+ // Wasm entries are to relocate pointers into the wasm memory embedded in
+ // wasm code. Everything after WASM_MEMORY_REFERENCE (inclusive) is not
+ // GC'ed.
WASM_MEMORY_REFERENCE,
WASM_GLOBAL_REFERENCE,
WASM_MEMORY_SIZE_REFERENCE,
@@ -356,7 +358,6 @@ class RelocInfo {
WASM_PROTECTED_INSTRUCTION_LANDING,
CELL,
- // Everything after runtime_entry (inclusive) is not GC'ed.
RUNTIME_ENTRY,
COMMENT,
@@ -396,7 +397,7 @@ class RelocInfo {
FIRST_REAL_RELOC_MODE = CODE_TARGET,
LAST_REAL_RELOC_MODE = VENEER_POOL,
LAST_CODE_ENUM = CODE_TARGET_WITH_ID,
- LAST_GCED_ENUM = WASM_FUNCTION_TABLE_SIZE_REFERENCE,
+ LAST_GCED_ENUM = EMBEDDED_OBJECT,
FIRST_SHAREABLE_RELOC_MODE = CELL,
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698