Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: tools/bots/pub.py

Issue 293083007: Also run pkg testing with optimization counter thresshold 5 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/pub.py
===================================================================
--- tools/bots/pub.py (revision 36416)
+++ tools/bots/pub.py (working copy)
@@ -48,14 +48,16 @@
common_args.append('--builder-tag=%s' % build_info.builder_tag)
- # Pub tests currently have a lot of timeouts when run in debug mode.
- # See issue 18479
- if build_info.mode == 'release':
- bot.RunTest('pub', build_info,
- common_args + ['pub', 'pkg', 'docs'])
- else:
- bot.RunTest('pub', build_info,
- common_args + ['pkg', 'docs'])
+ testing_options = ['', '--vm-options=--optimization-counter-threshold=5']
+ for options in testing_options:
+ if build_info.mode == 'release':
+ bot.RunTest('pub and pkg %s' % options, build_info,
+ common_args + [options, 'pub', 'pkg', 'docs'])
+ else:
+ # Pub tests currently have a lot of timeouts when run in debug mode.
+ # See issue 18479
+ bot.RunTest('pub and pkg %s' % options, build_info,
+ common_args + [options, 'pkg', 'docs'])
if build_info.mode == 'release':
pkgbuild_build_info = bot.BuildInfo('none', 'vm', build_info.mode,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698