Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 293083005: Allow debugger to step into Map and Set forEach callbacks (Closed)

Created:
6 years, 7 months ago by adamk
Modified:
6 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev, rossberg, arv (Not doing code reviews)
Visibility:
Public.

Description

Allow debugger to step into Map and Set forEach callbacks BUG=v8:3341 LOG=Y R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21403

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -0 lines) Patch
M src/collection.js View 2 chunks +4 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/debug-stepin-collections-foreach.js View 1 chunk +118 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
adamk
6 years, 7 months ago (2014-05-21 08:39:56 UTC) #1
Yang
On 2014/05/21 08:39:56, adamk wrote: LGTM!
6 years, 7 months ago (2014-05-21 08:44:52 UTC) #2
adamk
6 years, 7 months ago (2014-05-21 09:25:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21403 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698