Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: cc/scheduler/begin_frame_source_unittest.cc

Issue 2930813002: Avoid DCHECK in ExternalBeginFrameSource::GetMissedBeginFrameArgs caused by out of order frame time (Closed)
Patch Set: Addressed CR feedback Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/scheduler/begin_frame_source.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/begin_frame_source_unittest.cc
diff --git a/cc/scheduler/begin_frame_source_unittest.cc b/cc/scheduler/begin_frame_source_unittest.cc
index a4cf4b59268e9b5aa201c6ea9a58ef0adee4ed11..bff0d4682326db84decd0d0510f437bacf91fe06 100644
--- a/cc/scheduler/begin_frame_source_unittest.cc
+++ b/cc/scheduler/begin_frame_source_unittest.cc
@@ -15,6 +15,7 @@
#include "testing/gtest/include/gtest/gtest.h"
using testing::NiceMock;
+using testing::_;
namespace cc {
namespace {
@@ -573,5 +574,29 @@ TEST_F(ExternalBeginFrameSourceTest, OnBeginFrameChecksBeginFrameContinuity) {
source2.OnBeginFrame(args);
}
+// https://crbug.com/730218: Avoid DCHECK crash in
+// ExternalBeginFrameSource::GetMissedBeginFrameArgs.
+TEST_F(ExternalBeginFrameSourceTest, GetMissedBeginFrameArgs) {
+ BeginFrameArgs args = CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0,
+ 2, 10000, 10100, 100);
+ source_->OnBeginFrame(args);
+
+ EXPECT_BEGIN_FRAME_SOURCE_PAUSED(*obs_, false);
+ EXPECT_BEGIN_FRAME_USED_MISSED(*obs_, 0, 2, 10000, 10100, 100);
+ source_->AddObserver(obs_.get());
+ source_->RemoveObserver(obs_.get());
+
+ // Out of order frame_time. This might not be valid but still shouldn't
+ // cause a DCHECK in ExternalBeginFrameSource code.
+ args = CreateBeginFrameArgsForTesting(BEGINFRAME_FROM_HERE, 0, 2, 9999, 10100,
+ 101);
+ source_->OnBeginFrame(args);
+
+ EXPECT_CALL((*client_), OnNeedsBeginFrames(true)).Times(1);
+ EXPECT_BEGIN_FRAME_SOURCE_PAUSED(*obs_, false);
+ EXPECT_CALL(*obs_, OnBeginFrame(_)).Times(0);
+ source_->AddObserver(obs_.get());
+}
+
} // namespace
} // namespace cc
« no previous file with comments | « cc/scheduler/begin_frame_source.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698