Finish refactoring FixProcessor to use ChangeBuilder

Finish refactoring FixProcessor to use ChangeBuilder

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/6d8b7c8806a75839d243480320723c6b3aaeec32

[Brian Wilkerson, 2017-06-07 21:06:22]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2017-06-07 21:06:24]

There's more clean-up that could be done, but this moves everything from
SourceBuffer to ChangeBuilder.

[scheglov, 2017-06-07 21:27:32]

LGTM

https://codereview.chromium.org/2930793002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right):

https://codereview.chromium.org/2930793002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:654: await
changeBuilder.addFileEdit(file, fileStamp,
1. This code: new DartChangeBuilder(), then "addFileEdit(file, fileStamp"
repeats often in this class.

2. If we decide that we want to use file stamps at all, AnalysisDriver should
know this information, and keep it in FileState.

https://codereview.chromium.org/2930793002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:655:
(DartFileEditBuilder builder) {
3. Consider removing DartFileEditBuilder annotation to keep this code on one
line.

[Brian Wilkerson, 2017-06-08 14:56:10]

Description was changed from

==========
Finish refactoring FixProcessor to use ChangeBuilder
==========

to

==========
Finish refactoring FixProcessor to use ChangeBuilder

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6d8b7c8806a75839d243480320723c6b3aaeec32
==========

[Brian Wilkerson, 2017-06-08 14:56:11]

Committed patchset #1 (id:1) manually as
6d8b7c8806a75839d243480320723c6b3aaeec32 (presubmit successful).